speech: update to v1 #2175
Merged
speech: update to v1 #2175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
stephenplusplus
added
api: speech
landrito
approved these changes
Apr 3, 2017
callmehiphop
approved these changes
Apr 3, 2017
Contributor
callmehiphop
left a comment
callmehiphop
left a comment
There was a problem hiding this comment.
LGTM - my only question would be why are we including the gapic tests here?
Contributor
Author
|
Not sure: #1930 |
Contributor
|
For now, my vote is to leave them included (they may or may not actually run). We are working on a longer-term testing strategy for these. It is worth noting that while the development does not happen here, this is more or less the canonical location for GAPICs. :-/ I think the best way to do that ultimately is to have the generation process make a PR to this repo, and have the tests run that way, and rely less on api-client-staging as a canonical location. |
Contributor
Author
|
That's cool. |
|
|
||
| config = extend(true, { | ||
| config: { | ||
| languageCode: 'en-US' |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Speech API to v1.