Skip to content

Conversation

@anguillanneuf
Copy link
Contributor

@anguillanneuf anguillanneuf commented Aug 19, 2019

The old example exits immediately without receiving or printing messages, giving some users the impression that the sample doesn't work.
The updated one keeps the subscriber alive to listen to messages.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2019
Copy link
Member

@hongalex hongalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anguillanneuf
Copy link
Contributor Author

Thanks Alex!

@anguillanneuf anguillanneuf merged commit 4f5f3bf into master Aug 20, 2019
@anguillanneuf anguillanneuf deleted the subscriber branch August 20, 2019 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants