Update protobuf to 3.9.1 #6038
Merged
Update protobuf to 3.9.1 #6038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
|
Doesn't this change require a corresponding bump to synthtool so that we have protoc 3.9.1 there? |
Contributor
|
In theory, the generated code from an older version of protoc should be compatible with the newest protobuf version at runtime. The inverse is not the case. I will run this through all the integration tests (they are skipped in the presubmit here) |
Contributor
|
Spanner IT and Spanner JDBC IT tests failed. Spanner test failed with "INVALID_ARGUMENT: com.google.api.gax.rpc.InvalidArgumentException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT: projects/{project ID} is missing from uri." |
Contributor
|
gprc 1.23.0 has updated to 3.9 |
chingor13
approved these changes
Aug 16, 2019
This was referenced Aug 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.