Skip to content

Simplify release process #3799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chingor13 merged 6 commits into from
Oct 10, 2018
Merged

Simplify release process #3799

chingor13 merged 6 commits into from
Oct 10, 2018

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 10, 2018

These maven config changes make it so you no longer need to edit the root pom.xml file as part of the release process.

  • Moved the gpg signing and nexus-sonatype-staging-plugin to the artifacts that are releasable. This plugin replaces the deploy goal.
  • Skip maven-deploy-plugin for non-releasable artifacts.
  • Changes order of modules because a deployable artifact must be last.

@chingor13
Cleanup maven release goals
df08620
@chingor13
Only deploy the deployable artifacts.
cbbd364 
Only use the nexus-staging-maven-plugin on deployable assets.
Set skip to true for deployment on non-deployable assets.
@chingor13
Need to enable maven-gpg-plugin for release profile for google-cloud-…
c729a69 
…clients and google-api-grpc
@chingor13
Update release instructions. We no longer need to comment out the mod…
f369218 
…ules or plugin
@chingor13
Cleanup
dba8ef9
@chingor13 chingor13 requested review from a team and garrettjonesgoogle October 10, 2018 18:19
@chingor13 chingor13 requested a review from pongad as a code owner October 10, 2018 18:19
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
garrettjonesgoogle
garrettjonesgoogle reviewed Oct 10, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!!

google-cloud-clients/pom.xml Outdated
<failsOnError>true</failsOnError>
<includeTestSourceDirectory>true</includeTestSourceDirectory>
<excludes>com/google/cloud/*/v*/**</excludes><!-- We need to exclude autogenerated code -->
<excludes>com/google/cloud/*/v*/**,</excludes><!-- We need to exclude autogenerated code -->

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

garrettjonesgoogle
garrettjonesgoogle approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chingor13 chingor13 merged commit 76e09ee into googleapis:master Oct 10, 2018
@chingor13 chingor13 mentioned this pull request Oct 10, 2018
Closed
@chingor13 chingor13 deleted the release-profile branch October 10, 2018 22:21
This was referenced Oct 10, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pongad pongad Awaiting requested review from pongad

1 more reviewer

@garrettjonesgoogle garrettjonesgoogle garrettjonesgoogle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chingor13 @garrettjonesgoogle @googlebot