Skip to content

Conversation

@kurtisvg
Copy link
Contributor

@kurtisvg kurtisvg commented Apr 8, 2022

Change Description

Adds the WithDialIAMAuthN DialOption, for dialing an instance with an IAMAuthN option different than the Dialer setting.

@kurtisvg kurtisvg force-pushed the iam branch 2 times, most recently from eaeed12 to 9068938 Compare April 12, 2022 19:52
@kurtisvg kurtisvg force-pushed the iam branch 2 times, most recently from a765674 to ed8ede0 Compare May 27, 2022 20:18
@kurtisvg kurtisvg marked this pull request as ready for review May 31, 2022 01:40
@kurtisvg kurtisvg requested review from a team and enocom May 31, 2022 01:40
@kurtisvg kurtisvg changed the title feat: add WithDialIAMAuthN DialOption feat: add DialOption for IAM Authentication May 31, 2022
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things

@kurtisvg kurtisvg requested a review from enocom May 31, 2022 17:28
@kurtisvg kurtisvg changed the title feat: add DialOption for IAM Authentication feat: add DialOption for IAM DB Authentication May 31, 2022
Base automatically changed from warmup to main May 31, 2022 22:00
@kurtisvg kurtisvg merged commit c103acc into main Jun 1, 2022
@kurtisvg kurtisvg deleted the iam branch June 1, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants