Fix duplicate links not being preloaded #403
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Collaborator
|
@hadyan could you review this PR please? :) |
Collaborator
|
@addyosmani please review this PR too |
Merged
Merged
XhmikosR
force-pushed
the
fix-duplicate-links
branch
from
61e973f to
ce8a4b0
Compare
XhmikosR
force-pushed
the
fix-duplicate-links
branch
from
ce8a4b0 to
b9a5916
Compare
XhmikosR
force-pushed
the
fix-duplicate-links
branch
from
b9a5916 to
b175f65
Compare
- Index visible links by href first, by element second - Fixes issue GoogleChromeLabs#387 where duplicate links with identical hrefs won't preload at all if one link is visible and another one isn't
XhmikosR
force-pushed
the
fix-duplicate-links
branch
from
b175f65 to
8540821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #387