feat!: validate browser.createUserContext:proxy
#3662
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added
puppeteer
OrKoN
approved these changes
Aug 22, 2025
Collaborator
|
It looks like it would not be compatible with Puppeteer? |
browser-automation-bot
added a commit
to browser-automation-bot/chromium-bidi
that referenced
this pull request
Aug 22, 2025
sadym-chromium
pushed a commit
that referenced
this pull request
Aug 22, 2025
Update the expectations for PR #3662. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
sadym-chromium
changed the title
browser.createUserContext:proxybrowser.createUserContext:proxy
Collaborator
Author
It is compatible but it's a breaking change. In Puppeteer, we will have to parse the proxy string and strip out the schema from proxies per schema. |
Collaborator
Author
yeah, it's a breaking change due to w3c/webdriver#1920 |
sadym-chromium
pushed a commit
that referenced
this pull request
Aug 29, 2025
Update the expectations for PR #3662. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
sadym-chromium
force-pushed
the
sadym/browser.createUserContext.proxy
branch
from
ff83583 to
aa92ba3
Compare
Update the expectations for PR #3662. Automatically generated by https://github.com/GoogleChromeLabs/chromium-bidi/blob/main/.github/workflows/wpt.yml
sadym-chromium
force-pushed
the
sadym/browser.createUserContext.proxy
branch
from
aa92ba3 to
c6b2f1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on w3c/webdriver#1920
Spec: w3c/webdriver-bidi#988
Breaking change:
proxyparameter does not allow for schema.