misc(build): update devtools 3p readme, document debug build (#16695)

Author: connorjclark

build/build-report.js

@@ -60,7 +60,7 @@ async function buildFlowReport() {
     format: 'iife',
     charset: 'utf8',
     bundle: true,
-    minify: true,
+    minify: !process.env.DEBUG,
     plugins: [
       plugins.replaceModules({
         [`${LH_ROOT}/flow-report/src/i18n/localized-strings.js`]: buildFlowStrings(),
@@ -117,7 +117,7 @@ export const format = {registerLocaleData, hasLocale};
     outfile: 'dist/report/bundle.esm.js',
     format: 'esm',
     bundle: true,
-    minify: true,
+    minify: !process.env.DEBUG,
     plugins: [
       plugins.replaceModules({
         // Exclude this 30kb from the devtools bundle for now.

build/readme.md

@@ -16,6 +16,7 @@ To build the Lighthouse bundle for CDT and roll them into a local checkout of th
 
 ```sh
 yarn devtools
+DEBUG=1 yarn devtools # or use this command to skip minification
 ```
 
 One of the commands that the above runs - `yarn build-devtools` - creates these files:

core/scripts/roll-to-devtools.sh

@@ -86,13 +86,21 @@ echo "Name: Lighthouse
 Short Name: lighthouse
 Version: $PKG_VERSION
 Revision: $REVISION
+Update Mechanism: Manual
 URL: https://github.com/GoogleChrome/lighthouse
-License: Apache License 2.0
+License: Apache-2.0
 License File: LICENSE
 Security Critical: no
 Shipped: yes
 
-This directory contains Chromium's version of the lighthouse report assets, including renderer." > "$fe_lh_dir/README.chromium"
+This directory contains Chromium's version of Lighthouse. It includes:
+
+- locale strings
+- report assets
+- report renderer
+- worker bundle for running Lighthouse core
+
+Build documentation: https://github.com/GoogleChrome/lighthouse/blob/main/build/readme.md#building-for-devtools" > "$fe_lh_dir/README.chromium"
 
 echo ""
 echo "Done. To run the e2e tests: "

report/renderer/details-renderer.js

@@ -656,7 +656,6 @@ export class DetailsRenderer {
   /**
    * @param {LH.Audit.Details.SourceLocationValue} item
    * @return {Element|null}
-   * @protected
    */
   renderSourceLocation(item) {
     if (!item.url) {