Skip to content

Commit ce35809

Browse files
authored
Merge branch 'main' into 3p-cookie-str-update
2 parents 3165f6a + ca8b112 commit ce35809

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

cli/test/smokehouse/test-definitions/dobetterweb.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -268,7 +268,7 @@ const expectations = {
268268
},
269269
'render-blocking-resources': {
270270
score: '<1',
271-
numericValue: '>=85',
271+
numericValue: '>=50',
272272
details: {
273273
items: [
274274
{

third-party/devtools-tests/e2e/lighthouse/devtools-settings_test.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,12 @@ describe('DevTools', function() {
9393
statusCode: item.statusCode,
9494
};
9595
});
96-
assert.deepEqual(trimmedRequests, [
97-
{url: 'hello.html', statusCode: 200},
98-
{url: 'basic.css', statusCode: -1}, // statuCode === -1 means the request failed
99-
]);
96+
97+
// An extra basic.css request with status code -1 appears, but only in e2e tests
98+
// This test is made more lenient since this only happens in the e2e environment
99+
// b/359984292
100+
assert.deepStrictEqual(trimmedRequests[0], {url: 'hello.html', statusCode: 200});
101+
assert.deepStrictEqual(trimmedRequests[1], {url: 'basic.css', statusCode: -1});
100102
});
101103
});
102104

0 commit comments

Comments
 (0)