Skip to content

Commit 20044de

Browse files
authored
tests: update some comments (#16744)
1 parent c94a9d2 commit 20044de

2 files changed

Lines changed: 35 additions & 36 deletions

File tree

cli/test/smokehouse/test-definitions/byte-efficiency.js

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ const config = {
2828
// unsized-images is not a byte-efficiency audit but can easily leverage the variety of images present in
2929
// byte-efficiency tests & thus makes sense to test together.
3030
'unsized-images',
31+
'image-delivery-insight',
3132
],
3233
throttlingMethod: 'devtools',
3334
},
@@ -199,40 +200,40 @@ const expectations = {
199200
],
200201
},
201202
},
202-
// TODO(v13): why aren't any of these triggering the modern format reason?
203-
// 'image-delivery-insight': {
204-
// details: {
205-
// items: [
206-
// {
207-
// url: /lighthouse-1024x680.jpg$/,
208-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
209-
// },
210-
// {
211-
// url: /lighthouse-unoptimized.jpg$/,
212-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
213-
// },
214-
// {
215-
// url: /lighthouse-480x320.jpg$/,
216-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
217-
// },
218-
// {
219-
// url: /lighthouse-480x320.jpg\?attributesized/,
220-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
221-
// },
222-
// {
223-
// url: /lighthouse-480x320.jpg\?css/,
224-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
225-
// },
226-
// {
227-
// url: /lighthouse-480x320.jpg\?sprite/,
228-
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
229-
// },
230-
// ],
231-
// debugData: {
232-
// wastedBytes: '137000 +/- 10000',
233-
// },
234-
// },
235-
// },
203+
'image-delivery-insight': {
204+
details: {
205+
// TODO: modern image format suggestions need to be improved. See https://crbug.com/450085873
206+
// items: [
207+
// {
208+
// url: /lighthouse-1024x680.jpg$/,
209+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
210+
// },
211+
// {
212+
// url: /lighthouse-unoptimized.jpg$/,
213+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
214+
// },
215+
// {
216+
// url: /lighthouse-480x320.jpg$/,
217+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
218+
// },
219+
// {
220+
// url: /lighthouse-480x320.jpg\?attributesized/,
221+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
222+
// },
223+
// {
224+
// url: /lighthouse-480x320.jpg\?css/,
225+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
226+
// },
227+
// {
228+
// url: /lighthouse-480x320.jpg\?sprite/,
229+
// subItems: {items: {_includes: [{reason: /Using a modern image format/}]}},
230+
// },
231+
// ],
232+
debugData: {
233+
wastedBytes: '160000 +/- 10000',
234+
},
235+
},
236+
},
236237
'document-latency-insight': {
237238
score: '<1',
238239
details: {

cli/test/smokehouse/test-definitions/perf-trace-elements.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ const expectations = {
130130
},
131131
'cls-culprits-insight': {
132132
score: 1,
133-
// TODO(v13): should we add displayValue for this insight?
134-
// displayValue: '2 layout shifts found',
135133
details: {
136134
items: [
137135
{

0 commit comments

Comments
 (0)