-
Notifications
You must be signed in to change notification settings - Fork 143
perf: migrate from pre-commit to prek for performance improvement #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Goldziher
merged 13 commits into
kreuzberg-dev:main
from
kh3rld:feat/migrate-pre-commit-to-prek
Sep 22, 2025
Merged
perf: migrate from pre-commit to prek for performance improvement #142
Goldziher
merged 13 commits into
kreuzberg-dev:main
from
kh3rld:feat/migrate-pre-commit-to-prek
Sep 22, 2025
+31
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type ignore comment for torch assignment in _easyocr.py - Update uv.lock to reflect dependency changes These changes ensure all prek hooks pass successfully, including mypy type checking.
- Update installation instructions to use prek - Update command examples to use prek run - Update notes section to reference prek This completes the documentation migration to prek.
- Install prek and add to PATH - Cache prek environments - Run prek run --all-files instead of uv run pre-commit run Fix missing pre-commit binary error in CI.
- Change condition from 'always()' to 'needs.test-pr.result == success' - This prevents trying to download artifacts that were never uploaded - Fixes 'Artifact not found' error when test-pr job fails
…kh3rld/kreuzberg into feat/migrate-pre-commit-to-prek
- Add condition 'secrets.DEEPSOURCE_DSN != ''' to both DeepSource upload steps - This prevents workflow failure when the secret is not configured - DeepSource upload will be skipped gracefully if secret is missing
- Add 'needs.test-pr.result == success' condition to DeepSource uploads - This prevents DeepSource timeout when coverage artifacts are missing - DeepSource will only run when tests actually pass and upload artifacts
Goldziher
reviewed
Sep 22, 2025
- Replace curl script with 'uv tool install prek' in CI workflow - Update documentation to use uv installation method - Update ai-rulez.yaml with uv installation step - Ensures we always get the latest prek version automatically
Goldziher
added a commit
that referenced
this pull request
Dec 10, 2025
perf: migrate from pre-commit to prek for performance improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR migrates the project from
pre-committoprek, a faster, rust based drop-in replacement that provides significant performance improvements and enhanced developer experienceChanges Made
Core Migration
pre-commit>=4.3.0frompyproject.tomldev dependenciesTaskfile.ymlcommands (pre-committoprek)docs/contributing.mdai-rulez.yamldevelopment guidelinescloses #141