nullable warnings (#568)

* annotate code with ReSharper nullable attributes 
* add missing null-checks / cases 
* extract update checker form NugetWindow + rename asmdef

Author: JoC0de

.editorconfig

@@ -142,6 +142,13 @@ dotnet_diagnostic.sa1101.severity=none
 dotnet_diagnostic.SA1408.severity=none
 dotnet_diagnostic.SA1407.severity=none
 dotnet_diagnostic.SA1118.severity=none
+dotnet_diagnostic.CA1002.severity=none
+dotnet_diagnostic.CA1031.severity=none
+dotnet_diagnostic.CA1062.severity=none
+dotnet_diagnostic.CA2234.severity=none
+dotnet_diagnostic.CA2007.severity=none
+dotnet_diagnostic.CA1056.severity=none # URI-like properties should not be strings
+dotnet_diagnostic.CA1054.severity=none # URI parameters should not be strings
 # ReSharper properties
 resharper_wrap_after_declaration_lpar=true
 

.gitignore

@@ -2,3 +2,5 @@
 
 *.log
 **/.idea
+
+src/NuGetForUnity/Editor/NuGetForUnity.csproj*

src/Directory.Build.props

@@ -1,6 +1,6 @@
 <Project>
     <PropertyGroup>
-        <!-- To support Unity 2018.4 with .NET Framework we can not 'eayily' use features of C# higher than 7.3 -->
+        <!-- To support Unity 2018.4 with .NET Framework we can not 'easily' use features of C# higher than 7.3 -->
         <LangVersion>7.3</LangVersion>
     </PropertyGroup>
 

…uGetForUnity.Cli/Fakes/SerializeField.cs …ity.Cli/Fakes/SerializeFieldAttribute.cssrc/NuGetForUnity.Cli/Fakes/SerializeField.cs renamed to src/NuGetForUnity.Cli/Fakes/SerializeFieldAttribute.cs src/NuGetForUnity.Cli/Fakes/SerializeField.cs renamed to src/NuGetForUnity.Cli/Fakes/SerializeFieldAttribute.cs

@@ -31,4 +31,7 @@
         <Compile Remove="..\NuGetForUnity\Editor\OnLoadNugetPackageRestorer.cs" />
         <Compile Remove="..\NuGetForUnity\Editor\UnityPreImportedLibraryResolver.cs" />
     </ItemGroup>
+    <ItemGroup>
+        <PackageReference Include="JetBrains.Annotations" Version="2023.2.0" />
+    </ItemGroup>
 </Project>

src/NuGetForUnity.Cli/NuGetForUnity.Cli.csproj

@@ -0,0 +1,7 @@
+<wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
+    <s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=configuration/@EntryIndexedValue">False</s:Boolean>
+    <s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=helper/@EntryIndexedValue">False</s:Boolean>
+    <s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=models/@EntryIndexedValue">False</s:Boolean>
+    <s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=packagesource/@EntryIndexedValue">False</s:Boolean>
+    <s:Boolean x:Key="/Default/CodeInspection/NamespaceProvider/NamespaceFoldersToSkip/=ui/@EntryIndexedValue">False</s:Boolean>
+</wpf:ResourceDictionary>

src/NuGetForUnity.Tests/NuGetForUnity.csproj.DotSettings

@@ -4,6 +4,7 @@
 using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
+using JetBrains.Annotations;
 using NugetForUnity.Helper;
 using NugetForUnity.Models;
 using NugetForUnity.PackageSource;
@@ -21,11 +22,13 @@ public static class ConfigurationManager
         /// <summary>
         ///     The <see cref="INugetPackageSource" /> to use.
         /// </summary>
+        [CanBeNull]
         private static INugetPackageSource activePackageSource;
 
         /// <summary>
         ///     Backing field for the NuGet.config file.
         /// </summary>
+        [CanBeNull]
         private static NugetConfigFile nugetConfigFile;
 
         static ConfigurationManager()
@@ -40,11 +43,13 @@ static ConfigurationManager()
         /// <remarks>
         ///     <see cref="NugetConfigFile" />.
         /// </remarks>
+        [NotNull]
         public static string NugetConfigFilePath { get; }
 
         /// <summary>
         ///     Gets the loaded NuGet.config file that holds the settings for NuGet.
         /// </summary>
+        [NotNull]
         public static NugetConfigFile NugetConfigFile
         {
             get
@@ -54,13 +59,15 @@ public static NugetConfigFile NugetConfigFile
                     LoadNugetConfigFile();
                 }
 
+                Debug.Assert(nugetConfigFile != null, nameof(nugetConfigFile) + " != null");
                 return nugetConfigFile;
             }
         }
 
         /// <summary>
         ///     Gets the path to the directory containing the NuGet.config file.
         /// </summary>
+        [NotNull]
         internal static string NugetConfigFileDirectoryPath { get; }
 
         /// <summary>
@@ -70,6 +77,24 @@ public static NugetConfigFile NugetConfigFile
         /// </summary>
         internal static bool IsVerboseLoggingEnabled => nugetConfigFile?.Verbose ?? false;
 
+        /// <summary>
+        ///     Gets the <see cref="INugetPackageSource" /> to use.
+        /// </summary>
+        [NotNull]
+        private static INugetPackageSource ActivePackageSource
+        {
+            get
+            {
+                if (activePackageSource is null)
+                {
+                    LoadNugetConfigFile();
+                }
+
+                Debug.Assert(activePackageSource != null, nameof(activePackageSource) + " != null");
+                return activePackageSource;
+            }
+        }
+
         /// <summary>
         ///     Loads the NuGet.config file.
         /// </summary>
@@ -93,7 +118,7 @@ public static void LoadNugetConfigFile()
             {
                 if (readingSources)
                 {
-                    if (arg.StartsWith("-"))
+                    if (arg.StartsWith("-", StringComparison.Ordinal))
                     {
                         readingSources = false;
                     }
@@ -138,14 +163,16 @@ public static void LoadNugetConfigFile()
         /// <param name="numberToSkip">The number of packages to skip before fetching.</param>
         /// <param name="cancellationToken">Token that can be used to cancel the asynchronous task.</param>
         /// <returns>The list of available packages.</returns>
+        [NotNull]
+        [ItemNotNull]
         public static Task<List<INugetPackage>> Search(
-            string searchTerm = "",
+            [NotNull] string searchTerm = "",
             bool includePrerelease = false,
             int numberToGet = 15,
             int numberToSkip = 0,
             CancellationToken cancellationToken = default)
         {
-            return activePackageSource.Search(searchTerm, includePrerelease, numberToGet, numberToSkip, cancellationToken);
+            return ActivePackageSource.Search(searchTerm, includePrerelease, numberToGet, numberToSkip, cancellationToken);
         }
 
         /// <summary>
@@ -156,19 +183,22 @@ public static Task<List<INugetPackage>> Search(
         /// <param name="targetFrameworks">The specific frameworks to target?.</param>
         /// <param name="versionConstraints">The version constraints?.</param>
         /// <returns>A list of all updates available.</returns>
+        [NotNull]
+        [ItemNotNull]
         public static List<INugetPackage> GetUpdates(
-            IEnumerable<INugetPackage> packagesToUpdate,
+            [NotNull] IEnumerable<INugetPackage> packagesToUpdate,
             bool includePrerelease = false,
             string targetFrameworks = "",
             string versionConstraints = "")
         {
-            return activePackageSource.GetUpdates(packagesToUpdate, includePrerelease, targetFrameworks, versionConstraints);
+            return ActivePackageSource.GetUpdates(packagesToUpdate, includePrerelease, targetFrameworks, versionConstraints);
         }
 
         /// <inheritdoc cref="INugetPackageSource.GetSpecificPackage(INugetPackageIdentifier)" />
-        public static INugetPackage GetSpecificPackage(INugetPackageIdentifier nugetPackageIdentifier)
+        [CanBeNull]
+        public static INugetPackage GetSpecificPackage([NotNull] INugetPackageIdentifier nugetPackageIdentifier)
         {
-            return activePackageSource.GetSpecificPackage(nugetPackageIdentifier);
+            return ActivePackageSource.GetSpecificPackage(nugetPackageIdentifier);
         }
     }
 }