refactor(build): Simplify CI build flag logic

Globally sets continuous integration build for non-local builds, then explicitly disables it for unit tests to ensure consistent test execution.

Author: arturcic

build/build/BuildLifetime.cs

@@ -1,4 +1,3 @@
-using Build.Tasks;
 using Build.Utilities;
 using Common.Lifetime;
 using Common.Utilities;
@@ -18,7 +17,7 @@ public override void Setup(BuildContext context, ISetupContext info)
 
         if (context.Version is not null)
         {
-            SetMsBuildSettingsVersion(context, info);
+            SetMsBuildSettingsVersion(context);
         }
 
         context.StartGroup("Build Setup");
@@ -27,7 +26,7 @@ public override void Setup(BuildContext context, ISetupContext info)
         context.EndGroup();
     }
 
-    private static void SetMsBuildSettingsVersion(BuildContext context, ISetupContext info)
+    private static void SetMsBuildSettingsVersion(BuildContext context)
     {
         var msBuildSettings = context.MsBuildSettings;
         ArgumentNullException.ThrowIfNull(context.Version);
@@ -38,13 +37,7 @@ private static void SetMsBuildSettingsVersion(BuildContext context, ISetupContex
         msBuildSettings.SetPackageVersion(version.NugetVersion);
         msBuildSettings.SetFileVersion(version.Version);
         msBuildSettings.SetInformationalVersion(version.GitVersion.InformationalVersion);
-        var continuousIntegrationBuild = !(
-            context.IsLocalBuild
-            || info.TargetTask.Name == nameof(Test)
-            || info.TargetTask.Name == nameof(UnitTest)
-            || info.TargetTask.Name == nameof(PublishCoverage)
-        );
-        msBuildSettings.SetContinuousIntegrationBuild(continuousIntegrationBuild);
+        msBuildSettings.SetContinuousIntegrationBuild(!context.IsLocalBuild);
         msBuildSettings.WithProperty("RepositoryBranch", version.GitVersion.BranchName);
         msBuildSettings.WithProperty("RepositoryCommit", version.GitVersion.Sha);
         msBuildSettings.WithProperty("NoPackageAnalysis", "true");

build/build/Tasks/Test/UnitTest.cs

@@ -72,7 +72,9 @@ private static void TestProjectForTarget(BuildContext context, FilePath project,
             PathType = DotNetTestPathType.Project,
             Framework = $"net{framework}",
             Configuration = context.MsBuildConfiguration,
+            MSBuildSettings = new()
         };
+        settings.MSBuildSettings.SetContinuousIntegrationBuild(false);
 
         var resultsPath = context.MakeAbsolute(testResultsPath.CombineWithFilePath($"{projectName}.results.xml"));
         settings.WithArgumentCustomization(args => args