Skip to content

[GSK-3881] Fix RAGAS compatibility #2052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2024
Merged

[GSK-3881] Fix RAGAS compatibility #2052

merged 2 commits into from
Oct 29, 2024

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Oct 28, 2024 •
edited
Loading

Description

This PR fixes an import bug in which was making giskard not compatible with ragas==0.2.2.

Related Issue

#2051

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@linear
Copy link

linear bot commented Oct 28, 2024

GSK-3881 Check RAGAS compatibility

@henchaves henchaves self-assigned this Oct 28, 2024
@henchaves henchaves marked this pull request as ready for review October 28, 2024 14:15
@henchaves henchaves enabled auto-merge October 28, 2024 14:46
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@henchaves henchaves merged commit c0b167d into main Oct 29, 2024
17 checks passed
@henchaves henchaves deleted the feature/gsk-3881-check-ragas-compatibility branch October 29, 2024 08:17
@alexcombessie alexcombessie mentioned this pull request Oct 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinmessiaen kevinmessiaen kevinmessiaen approved these changes

@mattbit mattbit Awaiting requested review from mattbit

@pierlj pierlj Awaiting requested review from pierlj

Assignees

@henchaves henchaves

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@henchaves @kevinmessiaen