-
-
Notifications
You must be signed in to change notification settings - Fork 377
[GSK-1590] native support for claude 3 and titan embeddings on Bedrock #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-1590] native support for claude 3 and titan embeddings on Bedrock #1905
Conversation
|
Thanks a lot for this contribution @celmore25 ! We'll review it this week |
Those param will be ignored but that's not a big issue. Missing them would cause certain feature to totally fail using this model.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
I've done a small modification to ensure that the Client will still work when instructed to use format or seed. Those params aren't necessary for the model to work properly for the scan and tests since the format are also instructed in our promps and seeds are nice to have.
4f8c07f to
cff6057
Compare
|
@kevinmessiaen - I not aware why those parameters were there; thanks for fixing that and for the clarification :) Looks like the merge is blocked based on this failed test. I am not sure what the issue is here. I did not see any change with our commits would have impacted that integration test. Any thoughts here? |
It seems that the issue is global as we have it in other branches. I'll investigate and fix it on main so we can propagate the fix in other branches. PS: It seems that the error was caused by the release to mlflow 2.12.1 which cause an error with imbalance-learn |
mlflow 2.12.1 causes issues with imbalance-learn
|
Thanks for making the fix @kevinmessiaen |
Description
As the Claude models become more popular, it is helpful to provide native support for these models in an AWS environment. This feature adds native support for using an LLM client with Amazon Bedrock. As a first step, it supports the Claude 3 family of text generation models as well as the Titan text embedding models. Having implemented this myself, I have seen the QA sets produced by Haiku to be a great blend of speed and useful for a very low cost.
Here is how I envision this feature being used in the current library's implementation. This follows the test set generation example here.
Related Issue
GSK-1590
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.pdm.lockrunningpdm update-lock(only applicable whenpyproject.tomlhas beenmodified)