Skip to content

Conversation

@cy-moi
Copy link
Contributor

@cy-moi cy-moi commented Feb 15, 2024

Description

Previously, we removed the transformation column, which was not what we want. Because it is not obvious in the description. This PR hides the columns (data slice, transformation) only when they are empty.

Test: locally tested with Titanic
Demo: the scan report template posted here

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Feb 15, 2024

Copy link
Member

@Inokinoki Inokinoki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Inokinoki Inokinoki enabled auto-merge February 19, 2024 11:05
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Inokinoki Inokinoki merged commit c5c2774 into main Feb 19, 2024
@Inokinoki Inokinoki deleted the GSK-2270-hide-columns-when-null branch February 19, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants