Skip to content

[GSK-2574] Improve release process #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 31 commits into from
Feb 5, 2024
Merged

[GSK-2574] Improve release process #1773

merged 31 commits into from
Feb 5, 2024

Conversation

@vjern
Copy link
Contributor

@vjern vjern commented Jan 30, 2024 •
edited
Loading

Description

Update the release workflows to only create release artifacts (commit, tag, Github release and PyPI release) once all test suites have run.

See related ticket.

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@linear
Copy link

linear bot commented Jan 30, 2024

GSK-2574 Improve release step

@vjern vjern marked this pull request as ready for review January 30, 2024 17:03
@vjern vjern requested review from a team and Hartorn January 30, 2024 17:03
Hartorn
Hartorn reviewed Jan 31, 2024
View reviewed changes
Hartorn
Hartorn reviewed Jan 31, 2024
View reviewed changes
Hartorn
Hartorn reviewed Jan 31, 2024
View reviewed changes
Hartorn
Hartorn reviewed Jan 31, 2024
View reviewed changes
Hartorn
Hartorn reviewed Jan 31, 2024
View reviewed changes
@vjern vjern requested a review from Hartorn February 1, 2024 09:53
@vjern vjern force-pushed the feature/gsk-2574-improve-release-step branch from 146f510 to 825acf4 Compare February 1, 2024 16:23
@vjern vjern force-pushed the feature/gsk-2574-improve-release-step branch from 5515e2a to 4fd5a4b Compare February 2, 2024 10:57
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Hartorn Hartorn merged commit 951b31c into main Feb 5, 2024
@Hartorn Hartorn deleted the feature/gsk-2574-improve-release-step branch February 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Hartorn Hartorn Hartorn approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vjern @Hartorn