Skip to content

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Nov 27, 2023

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 27, 2023
@Hartorn Hartorn self-assigned this Nov 27, 2023
@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 27, 2023
@Hartorn Hartorn force-pushed the feat-tests-subprocess branch from 3b9cb2b to 779c3c0 Compare November 27, 2023 15:00
@Hartorn Hartorn added the Lockfile Temporary label to update pdm.lock label Nov 27, 2023
Copy link
Member

@kevinmessiaen kevinmessiaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good to me, that's a shame that we have to do this

@github-actions github-actions bot removed the Lockfile Temporary label to update pdm.lock label Nov 27, 2023
@Hartorn Hartorn changed the title Using a subprocess for pytest [GSK-2159] Using a subprocess for pytest Nov 27, 2023
@linear
Copy link

linear bot commented Nov 27, 2023

GSK-2159 Add a way to handle memory leak in pytest

At the moment, we are splitting the tests to avoid memory usage explosion

what we could do would be to twist a bit pytest-xdist, to make to stop and restart the workers it's using base on memory usage or number of tests ran.

Any way to make the tests run fine is ok, so it may not be the only solution

https://pypi.org/project/pytest-xdist/

@Hartorn Hartorn marked this pull request as ready for review November 27, 2023 15:16
@Hartorn Hartorn requested a review from a team November 27, 2023 15:16
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Hartorn Hartorn merged commit e23f327 into main Nov 27, 2023
@Hartorn Hartorn deleted the feat-tests-subprocess branch November 27, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants