-
-
Notifications
You must be signed in to change notification settings - Fork 381
[GSK-2179] Limit size of artifact name and display_name to 255 chars when uploading to Giskard Hub #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-2179] Limit size of artifact name and display_name to 255 chars when uploading to Giskard Hub #1639
Conversation
GSK-2179 Slicing function DB insert fails because of the long name #1605
If the feature name is long, it will cause issues when uploading scan result since generated function name will exceed the db max char allowed |
…ls-because-of-the-long-name
…ls-because-of-the-long-name
…b-insert-fails-because-of-the-long-name' into 1605-gsk-2179-slicing-function-db-insert-fails-because-of-the-long-name
Inokinoki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested with titanic (even though without special characters or exceeded length)
You can try with this code: import giskard
@giskard.slicing_function(name="🏃" * 500)
def sf_long_name(row):
return True
client = giskard.GiskardClient(
url="http://localhost:9000", # URL of your Giskard instance
key="gsk-...")
sf_long_name.upload(client, "project_key")I tried with different emojis and it worked (🧑🚒 counted as 5 characters, 👩👩👧👦 counted as 11, ...). |
…ls-because-of-the-long-name
|
Kudos, SonarCloud Quality Gate passed! |








Description
Limit size of artifact name and display_name to 255 chars when uploading to Giskard Hub
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.make codestyle.