Skip to content

Avoid uploading default params several times #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2023
Merged

Avoid uploading default params several times #1510

merged 1 commit into from
Oct 26, 2023

Conversation

@Hartorn
Copy link
Member

@Hartorn Hartorn commented Oct 26, 2023

Description

Add uploaded default params to uploaded uuid list

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@Hartorn Hartorn requested a review from rabah-khalek October 26, 2023 11:56
@Hartorn Hartorn self-assigned this Oct 26, 2023
@Hartorn Hartorn added the bug Something isn't working label Oct 26, 2023
@Hartorn Hartorn force-pushed the bugfix/avoid-multiple-upload branch from 0e3ed31 to 2a9474c Compare October 26, 2023 12:01
@Hartorn Hartorn changed the base branch from feature/llm-scan to main October 26, 2023 12:01
@Hartorn Hartorn closed this Oct 26, 2023
@Hartorn Hartorn reopened this Oct 26, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Hartorn Hartorn merged commit 4744997 into main Oct 26, 2023
@Hartorn Hartorn deleted the bugfix/avoid-multiple-upload branch October 26, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rabah-khalek rabah-khalek rabah-khalek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Hartorn Hartorn

Labels

bug Something isn't working

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Hartorn @rabah-khalek