Skip to content

Conversation

@henchaves
Copy link
Member

@henchaves henchaves commented Jul 12, 2023

Description

This PR aims to solve a lot of "console error" logs. The idea is to make everything working really well to migrate the frontend from Vue 2 to Vue 3 smoothly.
It modifies many files, so I apologise for the huge amount of code to review without being related to each other.

Related Issue

GSK-1408 (available on Linear)

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

@henchaves henchaves self-assigned this Jul 12, 2023
@linear
Copy link

linear bot commented Jul 12, 2023

GSK-1408 Fix console errors on frontend

  1. Migrate PredictionExplanations.vue to Composition API

  2. Interact with UI tabs (e.g. Debugger, Testing) and look for console errors (developer tools)

  3. Interact with paid license and look for console errors

  4. Solve these errors

@henchaves henchaves marked this pull request as ready for review July 18, 2023 14:36
params: {
projectId: props.projectId.toString()
}
}).catch(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a big fan of catching error and silencing them. Apparently a solution to update query params on the same route is to push the params only, but we will need to check if the route is the same or not each time...

await router.push({
    params: {
      projectId: props.projectId.toString()
    }
  })

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented this logic of checking if the route is the same or not, and it keeps displaying the Navigation error if I remove the catch statement

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@henchaves henchaves merged commit 83334be into main Jul 19, 2023
@Hartorn Hartorn deleted the feature/gsk-1408-fix-console-errors-on-frontend branch September 13, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants