-
-
Notifications
You must be signed in to change notification settings - Fork 378
[GSK-1408] Fix console errors on frontend #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSK-1408] Fix console errors on frontend #1242
Conversation
GSK-1408 Fix console errors on frontend
|
| params: { | ||
| projectId: props.projectId.toString() | ||
| } | ||
| }).catch(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a big fan of catching error and silencing them. Apparently a solution to update query params on the same route is to push the params only, but we will need to check if the route is the same or not each time...
await router.push({
params: {
projectId: props.projectId.toString()
}
})
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this logic of checking if the route is the same or not, and it keeps displaying the Navigation error if I remove the catch statement
|
Kudos, SonarCloud Quality Gate passed! |








Description
This PR aims to solve a lot of "console error" logs. The idea is to make everything working really well to migrate the frontend from Vue 2 to Vue 3 smoothly.
It modifies many files, so I apologise for the huge amount of code to review without being related to each other.
Related Issue
GSK-1408 (available on Linear)
Type of Change