Merge pull request #1528 from Giskard-AI/fix-gsk-1888-code-for-callable-functions-becomes-null

Remove auto-created `version` from mandatory fields

Author: Inokinoki

giskard/ml_worker/websocket/__init__.py

@@ -33,13 +33,13 @@ class TestFunctionArgument(BaseModel):
 
 
 # CallableMeta shows that all fields can be none,
-# but we have a pre-check here for Database constraints:
+# but we have a pre-check here for Database constraints except auto-created "version":
 # referring to `ai.giskard.domain.Callable` and `ai.giskard.domain.TestFunction`.
 class FunctionMeta(BaseModel):
     uuid: str
     name: str
     displayName: Optional[str] = None
-    version: int
+    version: Optional[int] = None
     module: Optional[str] = None
     doc: Optional[str] = None
     moduleDoc: Optional[str] = None
@@ -51,14 +51,14 @@ class FunctionMeta(BaseModel):
 
 
 # CallableMeta shows that all fields can be none,
-# but we have a pre-check here for Database constraints:
+# but we have a pre-check here for Database constraints except auto-created "version":
 # referring to `ai.giskard.domain.Callable`, `ai.giskard.domain.SlicingFunction`,
 # `ai.giskard.domain.TransformationFunction` and `ai.giskard.domain.DatasetProcessFunction`.
 class DatasetProcessFunctionMeta(BaseModel):
     uuid: str
     name: str
     displayName: Optional[str] = None
-    version: int
+    version: Optional[int] = None
     module: Optional[str] = None
     doc: Optional[str] = None
     moduleDoc: Optional[str] = None

tests/communications/test_dto_serialization.py

@@ -25,7 +25,7 @@
     "DataFrame": ["rows"],
     "DataRow": ["columns"],
     "DatasetMeta": [],
-    "DatasetProcessFunctionMeta": ["uuid", "name", "code", "version", "cellLevel"],
+    "DatasetProcessFunctionMeta": ["uuid", "name", "code", "cellLevel"],
     "DatasetProcessing": ["datasetId", "totalRows"],
     "DatasetProcessingFunction": [],
     "DatasetProcessingParam": ["dataset"],
@@ -39,7 +39,7 @@
     "ExplainTextParam": ["model", "feature_name", "columns", "column_types"],
     "Explanation": ["per_feature"],
     "FuncArgument": ["name", "none"],
-    "FunctionMeta": ["uuid", "name", "code", "version"],
+    "FunctionMeta": ["uuid", "name", "code"],
     "GenerateTestSuite": [],
     "GenerateTestSuiteParam": ["project_key"],
     "GeneratedTestInput": ["name", "value", "is_alias"],
@@ -89,6 +89,7 @@
     "DataRow": [],
     "DatasetMeta": ["target"],
     "DatasetProcessFunctionMeta": [
+        "version",
         "displayName",
         "module",
         "doc",
@@ -124,6 +125,7 @@
         "args",
     ],
     "FunctionMeta": [
+        "version",
         "displayName",
         "module",
         "doc",