Skip to content

Commit 8e2fac6

Browse files
Merge pull request #2071 from Giskard-AI/2061-test-output-in-range-indexing-error-while-using-slicing-function-for-classification-problem
Fixed boolean indexer mismatching issue
2 parents 1cde456 + 0b23355 commit 8e2fac6

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

.github/workflows/build-python.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ jobs:
120120
uses: pdm-project/setup-pdm@v4
121121
with:
122122
python-version: ${{ matrix.python-version }}
123+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
123124
cache: false
124125

125126
- name: Cache Giskard test resources
@@ -251,6 +252,7 @@ jobs:
251252
uses: pdm-project/setup-pdm@v4
252253
with:
253254
python-version: "3.10"
255+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
254256
cache: false
255257
- name: Build wheel
256258
run: pdm build
@@ -273,6 +275,7 @@ jobs:
273275
uses: pdm-project/setup-pdm@v4
274276
with:
275277
python-version: "3.10"
278+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
276279
cache: false
277280
- name: Build wheel
278281
run: pdm build
@@ -292,15 +295,15 @@ jobs:
292295
uses: pdm-project/setup-pdm@v4
293296
with:
294297
python-version: "3.10"
295-
version: "2.10.4" # Fix to repair the CI, use latest version when fixed on pdm
298+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
296299
cache: false
297300
- name: Build wheel
298301
run: pdm build
299302
- name: Create new project, install wheel and import (PDM)
300303
run: |
301304
mkdir ./install-run
302305
cd ./install-run
303-
pdm init --python 3.10 -n .
306+
pdm init --python 3.10 -n
304307
sed -i 's/^\(requires-python *= *\).*$/\1">=3.10,<3.12"/' pyproject.toml
305308
pdm add "$(ls ../dist/*.whl)"
306309
pdm run python -c "import giskard"
@@ -336,6 +339,7 @@ jobs:
336339
uses: pdm-project/setup-pdm@v4
337340
with:
338341
python-version: "3.10"
342+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
339343
cache: false
340344

341345
- name: Set up Pandoc (needed for doc)

.github/workflows/create-release.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ jobs:
5252
uses: pdm-project/setup-pdm@v4
5353
with:
5454
python-version: '3.10'
55+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
5556
cache: false
5657

5758
- name: "@slack Release process started"

.github/workflows/lock-deps.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ jobs:
5555
uses: pdm-project/setup-pdm@v4
5656
with:
5757
python-version: "3.10"
58+
version: head # Issue with PDM 2.20.1: https://github.com/pdm-project/pdm/issues/3271
5859
cache: false
5960

6061
- name: Install dependencies

giskard/testing/tests/statistic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_output_in_range(
145145
output = prediction_results.raw_prediction
146146

147147
elif model.is_classification:
148-
output = prediction_results.all_predictions[classification_label]
148+
output = prediction_results.all_predictions[classification_label].values
149149

150150
else:
151151
raise ValueError(f"Prediction task is not supported: {model.meta.model_type}")

0 commit comments

Comments
 (0)