Revert "fix: checks type in helper functions"

src/giskard_hub/data/_base.py

@@ -68,8 +68,5 @@ def to_dict(self) -> Dict[str, Any]:
 def maybe_to_dict(data):
     if isinstance(data, BaseData):
         return data.to_dict()
-    if isinstance(data, (list, tuple)):
-        return [maybe_to_dict(item) for item in data]
-    if isinstance(data, dict):
-        return {k: maybe_to_dict(v) for k, v in data.items()}
+
     return data

src/giskard_hub/data/conversation.py

@@ -3,9 +3,41 @@
 from dataclasses import dataclass, field
 from typing import Any, Dict, List, Optional
 
+from ._base import BaseData
 from ._entity import Entity
 from .chat import ChatMessage, ChatMessageWithMetadata
-from .check import CheckConfig, _format_checks_to_cli
+
+
+def _format_checks_to_cli(checks: List[TestCaseCheckConfig]) -> List[CheckConfig]:
+    return [
+        {
+            "identifier": check["identifier"],
+            "enabled": check["enabled"],
+            **(
+                {"params": params}
+                if check.get("assertions")
+                and (
+                    params := {
+                        k: v for k, v in check["assertions"][0].items() if k != "type"
+                    }
+                )
+                else {}
+            ),
+        }
+        for check in checks
+    ]
+
+
+@dataclass
+class CheckConfig(BaseData):
+    identifier: str
+    params: Optional[dict[str, Any]] = None
+
+
+@dataclass
+class TestCaseCheckConfig(BaseData):
+    identifier: str
+    assertions: List[dict[str, Any]]
 
 
 @dataclass
@@ -20,14 +52,14 @@ class Conversation(Entity):
         Output of the agent for demonstration purposes.
     tags : List[str], optional
         List of tags for the conversation.
-    checks : List[CheckConfig], optional
+    checks : List[TestCaseCheckConfig], optional
         List of checks to be performed on the conversation.
     """
 
     messages: List[ChatMessage] = field(default_factory=list)
     demo_output: Optional[ChatMessageWithMetadata] = field(default=None)
     tags: List[str] = field(default_factory=list)
-    checks: List[CheckConfig] = field(default_factory=list)
+    checks: List[TestCaseCheckConfig] = field(default_factory=list)
 
     @classmethod
     def from_dict(cls, data: Dict[str, Any], **kwargs) -> "Conversation":

src/giskard_hub/resources/conversations.py

@@ -4,11 +4,24 @@
 
 from ..data._base import NOT_GIVEN, filter_not_given, maybe_to_dict
 from ..data.chat import ChatMessage, ChatMessageWithMetadata
-from ..data.check import CheckConfig, _format_checks_to_backend
-from ..data.conversation import Conversation
+from ..data.conversation import CheckConfig, Conversation, TestCaseCheckConfig
 from ._resource import APIResource
 
 
+def _format_checks_to_backend(checks: list[CheckConfig]) -> list[TestCaseCheckConfig]:
+    return [
+        {
+            **check,
+            **(
+                {"assertions": [{"type": check["identifier"], **check["params"]}]}
+                if check.get("params")
+                else {}
+            ),
+        }
+        for check in checks
+    ]
+
+
 class ConversationsResource(APIResource):
     def retrieve(self, conversation_id: str):
         return self._client.get(
@@ -35,9 +48,7 @@ def create(
                 "messages": [maybe_to_dict(msg) for msg in messages],
                 "demo_output": maybe_to_dict(demo_output),
                 "tags": tags,
-                "checks": [
-                    maybe_to_dict(check) for check in _format_checks_to_backend(checks)
-                ],
+                "checks": _format_checks_to_backend(checks),
             }
         )
 
@@ -66,14 +77,7 @@ def update(
                 ),
                 "demo_output": maybe_to_dict(demo_output),
                 "tags": tags,
-                "checks": (
-                    [
-                        maybe_to_dict(check)
-                        for check in _format_checks_to_backend(checks)
-                    ]
-                    if checks
-                    else checks
-                ),
+                "checks": _format_checks_to_backend(checks) if checks else checks,
             }
         )