fix: upload file/image and respect app settings #2976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ve into file-upload-issue-fix-app-settings
Contributor
SDK Size
|
isekovanic
approved these changes
Feb 24, 2025
isekovanic
reviewed
Feb 24, 2025
| cancelled: false, | ||
| duration: photo.duration, // in milliseconds | ||
| name: 'video_recording_' + date + photo.uri.split('.').pop(), | ||
| name: 'video_recording_' + date + '.' + photo.uri.split('.').pop(), |
Contributor
There was a problem hiding this comment.
I really don't like how we sort of blindly do this - this can break on so many levels. Let's merge since it appears to never have worked but we need to fix this soon.
Contributor
|
🎉 This PR is included in version 6.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
isekovanic
added a commit
that referenced
this pull request
Feb 24, 2025
* chore: upgrade SampleApp and do necessary changes for 0.77 * chore: update more libs * chore: upgrade reanimated and rngh * chore: upgrade react-navigation * chore: bump other deps * chore: bump eslint and all other dev deps * chore: migrate AppDelegate to Swift * chore: upgrade typescript app to RN 0.77 * chore: upgrade eslint & friends on typescript app * chore: migrate AppDelegate to Swift in typescript app * fix: add tslint rules and fix some * chore: upgrade plugins decl a bit and fix all broken eslint issues * fix: some more prettier errors * chore: improve typescript app config too * fix: upload file/image and respect app settings (#2976) * fix: file upload preview state refresh when state changes * fix: upload file/image and respect app settings * fix: upload file/image and respect app settings * fix: upload file/image and respect app settings * fix: update expo dependencies in expo sample app to latest (#2975) * fix: file upload preview state refresh when state changes * fix: update expo dependencies in expo sample app to latest * chore: bump expo app to latest versions too * chore: remove console.log --------- Co-authored-by: Khushal Agarwal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with a file name that has been fixed, which is why Lookup could not look into the correct file type. Also, the mimeType is added for native CLI uploads and a check in the
isUploadAllowedfunction for mimeType and then check for name.The name of the image capture file has also been added for better parity with checks.
This should fix #2967