Skip to content

feat: add channel message count response fields#1594

Merged
javierdfm merged 4 commits intomasterfrom
cha-1045-add-channel-message-count-response
Aug 14, 2025
Merged

feat: add channel message count response fields#1594
javierdfm merged 4 commits intomasterfrom
cha-1045-add-channel-message-count-response

Conversation

@javierdfm
Copy link
Contributor

@javierdfm javierdfm commented Jul 31, 2025

CLA

  • I have signed the Stream CLA (required).
  • Code changes are tested

Description of the changes, What, Why and How?

Changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 31, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 454 kB

ℹ️ View Unchanged
Filename Size
dist/cjs/index.browser.cjs 130 kB
dist/cjs/index.node.cjs 182 kB
dist/esm/index.js 142 kB

compressed-size-action

MartinCupela
MartinCupela reviewed Aug 4, 2025
View reviewed changes
@javierdfm javierdfm requested a review from MartinCupela August 4, 2025 07:50
@MartinCupela
Copy link
Contributor

MartinCupela commented Aug 4, 2025

@javierdfm one more thing comes to my mind is the naming of the config field message_count_enabled. None of the rest of the fields has this enabled appended even though all of the fields there are about enabling / disabling a feature. And the name message_count does not say much about what is being enabled.

Is this feature a message_count_in_channel_payload?
Is this the total message count?
Including the moderated messages?

@javierdfm
Copy link
Contributor Author

javierdfm commented Aug 4, 2025

@javierdfm one more thing comes to my mind is the naming of the config field message_count_enabled. None of the rest of the fields has this enabled appended even though all of the fields there are about enabling / disabling a feature. And the name message_count does not say much about what is being enabled.

Is this feature a message_count_in_channel_payload? Is this the total message count? Including the moderated messages?

The feature enables counting messages in a channel (user generated messages like regular and replies) and exposing this count to the clients so it can be shown in the overview. Let me see if I can come up with a better name if this is not clear.

@javierdfm javierdfm merged commit c58fd6f into master Aug 14, 2025
4 checks passed
@javierdfm javierdfm deleted the cha-1045-add-channel-message-count-response branch August 14, 2025 09:01
github-actions bot pushed a commit that referenced this pull request Aug 14, 2025
@semantic-release-bot
chore(release): 9.16.0 [skip ci]
d73dd2a 
## [9.16.0](v9.15.0...v9.16.0) (2025-08-14)

### Features

* add channel message count response fields ([#1594](#1594)) ([c58fd6f](c58fd6f))
@stream-ci-bot
Copy link

stream-ci-bot commented Aug 14, 2025

🎉 This PR is included in version 9.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MartinCupela MartinCupela MartinCupela approved these changes

@vishalnarkhede vishalnarkhede Awaiting requested review from vishalnarkhede vishalnarkhede is a code owner

@santhoshvai santhoshvai Awaiting requested review from santhoshvai santhoshvai is a code owner

@khushal87 khushal87 Awaiting requested review from khushal87 khushal87 is a code owner

@szuperaz szuperaz Awaiting requested review from szuperaz szuperaz is a code owner

@oliverlaz oliverlaz Awaiting requested review from oliverlaz oliverlaz is a code owner

@arnautov-anton arnautov-anton Awaiting requested review from arnautov-anton arnautov-anton is a code owner

@myandrienko myandrienko Awaiting requested review from myandrienko

Assignees

No one assigned

Labels

released on @latest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@javierdfm @MartinCupela @stream-ci-bot