feat: query channels request override#1583
Merged
isekovanic merged 4 commits intomasterfrom Jul 23, 2025
Merged
Conversation
Contributor
|
Size Change: +194 B (+0.04%) Total Size: 433 kB
|
6 tasks
MartinCupela
approved these changes
Jul 23, 2025
oliverlaz
approved these changes
Jul 23, 2025
|
🎉 This PR is included in version 9.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
This PR introduces a way for integrators to override the default
ChannelManager'squeryChannels(which is essentiallyclient.queryChannels.This is particularly useful in certain niche' edge cases, where for example if querying channels relies heavily on
{ cid: { $in: [...] }}filters (or something similar) it would be impossible to properly paginate through everything as changing thefilterson the fly causes the entire state to be wiped as it's considered to be a brand new query.It also comes with a set of rules:
client.queryChannelsmust always be invoked by this override (the reason being thatqueryChannelsadditionally does a bunch of state updates under the hood, so it's mandatory that this is run)filtersstay intact during all of this (if they change, theChannelManagerwill consider this to be a brand new query and wipe everything)limitandoffset, so that pagination works properly (this comes as a given since we pin specific IDs, but worth mentioning still)Changelog