fix: allow the composition of unchanged edited message#1578
Merged
MartinCupela merged 2 commits intomasterfrom Jul 7, 2025
Merged
fix: allow the composition of unchanged edited message#1578MartinCupela merged 2 commits intomasterfrom
MartinCupela merged 2 commits intomasterfrom
Conversation
MartinCupela
requested review from
arnautov-anton,
khushal87,
myandrienko,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: -63 B (-0.01%) Total Size: 433 kB
|
khushal87
approved these changes
Jul 7, 2025
|
🎉 This PR is included in version 9.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Fixes GetStream/stream-chat-react#2756
We cannot reliably determine whether a message has changed semantically - e.g. adding a character and removing the same character gets us back to the initial state, but from the editing-timestamp point of view the message has changed. We would have to introduce a more sophisticated logic to determine, whether a message has changed semantically.