refactor: protect ReminderPaginator filters and sort properties#1567
Merged
MartinCupela merged 2 commits intomasterfrom Jun 19, 2025
Merged
Conversation
MartinCupela
requested review from
arnautov-anton,
khushal87,
myandrienko,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
Contributor
|
Size Change: +146 B (+0.03%) Total Size: 430 kB
|
oliverlaz
approved these changes
Jun 19, 2025
MartinCupela
deleted the
feat/protect-reminder-paginator-filters-and-sort
branch
github-actions bot
pushed a commit
that referenced
this pull request
Jun 19, 2025
## [9.8.0](v9.7.0...v9.8.0) (2025-06-19) ### Bug Fixes * allow to nullify reminder's remind_at value ([#1569](#1569)) ([c1c6cf4](c1c6cf4)) * propagate stopTimerRefreshBoundaryMs to all reminder timers on ReminderManager config update ([#1568](#1568)) ([944d1c2](944d1c2)) * run onChange middleware on TextComposer.insertText ([#1570](#1570)) ([3768007](3768007)) ### Features * handle command injection optionally ([#1548](#1548)) ([ea912f9](ea912f9)) ### Refactors * protect ReminderPaginator filters and sort properties ([#1567](#1567)) ([1a3f4c4](1a3f4c4))
|
🎉 This PR is included in version 9.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make sure to reset pagination state on
filterandsortchange so that the pagination state cannot get corrupted in the middle of pagination process due to the change offilterorsortvalues.