feat: add static location and live location support#1423
Merged
MartinCupela merged 34 commits intomasterfrom Jul 23, 2025
Merged
feat: add static location and live location support#1423MartinCupela merged 34 commits intomasterfrom
MartinCupela merged 34 commits intomasterfrom
Conversation
8efe2d6 to
b3cfe1f
Compare
b3cfe1f to
36d56e1
Compare
Contributor
|
Size Change: +7.75 kB (+1.79%) Total Size: 441 kB
|
# Conflicts: # src/channel.ts # src/events.ts # src/index.ts # src/types.ts
…iew and LiveLocationComposerLocation to LiveLocationPreview
# Conflicts: # src/channel.ts
khushal87
reviewed
Jul 18, 2025
khushal87
reviewed
Jul 18, 2025
Member
|
I am unable to send a location message in a thread. Is it in the spec? I see there's an early exit in the code for |
Contributor
I think this stems from the spec API definition - there is no place for thread id info in the methods signatures |
khushal87
approved these changes
Jul 21, 2025
5d64d66 to
9b126e7
Compare
|
🎉 This PR is included in version 9.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
LocationComposerclass - allows to compose a message with a shared_locationlive_location_sharing.started,live_location_sharing.stoppedChannel.sendSharedLocation- sends a message with a newshared_locationfieldChannel.stopLiveLocationSharing- dispatches locallive_location_sharing.stoppedevent to notifyLiveLocationManagerinstances (should probably just update message attachment withstopped_sharinginstead)LiveLocationManagerclass - reports location (client.updateSharedLocation) updates to the server for all the messages