Skip to content

Commit 279c6d2

Browse files
authored
fix(llc): Use extraData for name in ConnectUserDetails (#2451)
1 parent d8556e2 commit 279c6d2

File tree

3 files changed

+12
-2
lines changed

3 files changed

+12
-2
lines changed

packages/stream_chat/CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,10 @@
1+
## Upcoming
2+
3+
🐞 Fixed
4+
5+
- Fixed user's ID from being inadvertently used as their display name during the WebSocket
6+
connection process. [[#2447]](https://github.com/GetStream/stream-chat-flutter/issues/2447)
7+
18
## 9.20.0
29

310
✅ Added

packages/stream_chat/lib/src/ws/connect_user_details.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import 'package:json_annotation/json_annotation.dart';
22
import 'package:stream_chat/src/core/models/own_user.dart';
33
import 'package:stream_chat/src/core/models/privacy_settings.dart';
4+
import 'package:stream_chat/src/core/util/extension.dart';
45
import 'package:stream_chat/src/core/util/serializer.dart';
56

67
part 'connect_user_details.g.dart';
@@ -35,7 +36,8 @@ class ConnectUserDetails {
3536
factory ConnectUserDetails.fromOwnUser(OwnUser user) {
3637
return ConnectUserDetails(
3738
id: user.id,
38-
name: user.name,
39+
// Using extraData value in order to not use id as name.
40+
name: user.extraData['name'].safeCast<String>(),
3941
image: user.image,
4042
language: user.language,
4143
invisible: user.invisible,

packages/stream_chat_flutter/lib/src/attachment/thumbnail/image_attachment_thumbnail.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ class StreamImageAttachmentThumbnail extends StatelessWidget {
9090

9191
// If the remote image URL is available, we can directly show it using
9292
// the _RemoteImageAttachment widget.
93-
if (image.thumbUrl ?? image.imageUrl case final imageUrl?) {
93+
final imageUrl = image.thumbUrl ?? image.imageUrl ?? image.assetUrl;
94+
if (imageUrl case final imageUrl?) {
9495
var resizedImageUrl = imageUrl;
9596
if (effectiveThumbnailSize case final thumbnailSize?) {
9697
resizedImageUrl = imageUrl.getResizedImageUrl(

0 commit comments

Comments
 (0)