From d0ac31eb82375efc3ff248bb41b67689a9a254c8 Mon Sep 17 00:00:00 2001 From: Tim Shedor Date: Fri, 6 Feb 2026 10:08:23 -0800 Subject: [PATCH 1/4] eng: loosen rubocop restrictions ECOMM-7882 --- config/default.yml | 22 +++++++++++++++++----- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/config/default.yml b/config/default.yml index f7c3b0e..9483b68 100644 --- a/config/default.yml +++ b/config/default.yml @@ -77,21 +77,27 @@ Layout/SpaceInsideBlockBraces: Layout/SpaceInsideHashLiteralBraces: EnforcedStyle: no_space +Metrics/AbcSize: + Max: 30 + # Exclude RSpec Metrics/BlockLength: Exclude: - "spec/factories/**/*.rb" AllowedMethods: ['describe', 'context'] -# Too short methods lead to extraction of single-use methods, which can make -# the code easier to read (by naming things), but can also clutter the class -Metrics/MethodLength: - Max: 20 - # The guiding principle of classes is SRP, SRP can't be accurately measured by LoC Metrics/ClassLength: Max: 1500 +Metrics/CyclomaticComplexity: + Max: 15 + +# Too short methods lead to extraction of single-use methods, which can make +# the code easier to read (by naming things), but can also clutter the class +Metrics/MethodLength: + Max: 40 + # Check with yard instead. Style/DocumentationMethod: Enabled: false @@ -290,6 +296,12 @@ Rails/I18nLocaleTexts: RSpec/ContextWording: Enabled: false +RSpec/ExampleLength: + Max: 20 + +RSpec/MultipleExpectations: + Enabled: false + RSpec/AlignLeftLetBrace: Enabled: true From 6cd7f4cb234e74dc79dca40975bf0092cbf62fce Mon Sep 17 00:00:00 2001 From: Tim Shedor Date: Fri, 6 Feb 2026 10:14:19 -0800 Subject: [PATCH 2/4] too far --- config/default.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/default.yml b/config/default.yml index 9483b68..e56745c 100644 --- a/config/default.yml +++ b/config/default.yml @@ -78,7 +78,7 @@ Layout/SpaceInsideHashLiteralBraces: EnforcedStyle: no_space Metrics/AbcSize: - Max: 30 + Max: 25 # Exclude RSpec Metrics/BlockLength: @@ -91,7 +91,7 @@ Metrics/ClassLength: Max: 1500 Metrics/CyclomaticComplexity: - Max: 15 + Max: 12 # Too short methods lead to extraction of single-use methods, which can make # the code easier to read (by naming things), but can also clutter the class From 866fe8ea2dd1dcf1fcd1430227475fcadd384c31 Mon Sep 17 00:00:00 2001 From: Tim Shedor Date: Fri, 6 Feb 2026 11:13:47 -0800 Subject: [PATCH 3/4] enable multiple restrictions --- config/default.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/config/default.yml b/config/default.yml index e56745c..15b9cc5 100644 --- a/config/default.yml +++ b/config/default.yml @@ -299,9 +299,6 @@ RSpec/ContextWording: RSpec/ExampleLength: Max: 20 -RSpec/MultipleExpectations: - Enabled: false - RSpec/AlignLeftLetBrace: Enabled: true From 9489b201b5a911eddbddf59aff85da68870095b4 Mon Sep 17 00:00:00 2001 From: Tim Shedor Date: Fri, 6 Feb 2026 11:15:11 -0800 Subject: [PATCH 4/4] bump version --- lib/Dutchie/Style/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Dutchie/Style/version.rb b/lib/Dutchie/Style/version.rb index 7534a30..1b761c6 100644 --- a/lib/Dutchie/Style/version.rb +++ b/lib/Dutchie/Style/version.rb @@ -2,7 +2,7 @@ module Dutchie module Style - VERSION = "2.1.0" + VERSION = "2.1.1" public_constant :VERSION end end