Skip to content

Check if requested length would overflow in do_parse, chain and tuple #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Geal merged 5 commits into from
Apr 3, 2017
Merged

Check if requested length would overflow in do_parse, chain and tuple #486

Geal merged 5 commits into from
Apr 3, 2017

Conversation

@chifflier
Copy link
Contributor

@chifflier chifflier commented Mar 27, 2017

This fixes #481 by using overflowing_add, in case the requested value would overflow when computing Needed(consumed + needed).

@chifflier chifflier changed the title Check if requested length would overflow in do_parse Check if requested length would overflow in do_parse, chain and tuple Mar 28, 2017
@Geal Geal merged commit 9dd554e into rust-bakery:master Apr 3, 2017
@Geal
Copy link
Collaborator

Geal commented Apr 3, 2017

Thanks!

@daniellockyer daniellockyer mentioned this pull request Apr 4, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Panic in do_parse with take

2 participants

@chifflier @Geal