Optimize clone and extend
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `thin-vec` is included in rustc via "path" rather than via "version", these warnings occur. They are all part of the `rust_2018_idioms` lint. I don't really understand why they occur, but fixing them seems harmless?
`Vec::extend` is likewise inlined.
Contributor
Author
|
Best reviewed one commit at a time. |
Currently it reserves capacity using `with_capacity`. It then calls `extend`, which (unnecessarily) calls `reserve`. It then calls `push` N times, each of which (unnecessarily) does a capacity check.
nnethercote
force-pushed
the
opt-clone-and-extend
branch
from
9a72ec1 to
6780695
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small performance wins I found while integrating
ThinVecinto rustc.