adding new Reweight calculator for new hA2025 FSI model #42
Conversation
M7medS3d
changed the title
nusense
left a comment
nusense
left a comment
There was a problem hiding this comment.
This isn't a full review, but a few concerns that come up upon a semi-cursory look
| temp_map[ kXSecTwkDial_CoulombCCQE ] = "CoulombCCQE"; | ||
| temp_map[ kXSecTwkDial_NormCCCOHpi ] = "NormCCCOH"; | ||
| temp_map[ kXSecTwkDial_NormNCCOHpi ] = "NormNCCOH"; | ||
| temp_map[ kXSecTwkDial_ZExpELFF ] = "ZExpELFFCCQE"; |
There was a problem hiding this comment.
Was it intended that kXSecTwkDial_ZExpELFF* be removed when adding kINukehA2025_cex; or are these being excised by accident from working with an outdated version of the code?
There was a problem hiding this comment.
oh sorry these were removed by mistake.
| if ( !fsi_enabled ) { | ||
| LOG( "ReW", pERROR ) << "FSIs are not enabled for the current tune." | ||
| << " Refusing to reweight FSIs."; | ||
| std::exit( 1 ); |
There was a problem hiding this comment.
If the code is going to exit(1) then the LOG message should be using pFATAL level.
| AlgFactory* algf = AlgFactory::Instance(); | ||
|
|
||
| Algorithm* alg = algf->AdoptAlgorithm( id ); | ||
| fFSIModel = dynamic_cast< HAIntranuke2018* >( alg ); |
There was a problem hiding this comment.
I want to understand what the intent of this code is. Is it to take HAIntranuke2018 to HAIntranuke2025? Is there code to check that the input was generated with HAIntranuke2018?
There was a problem hiding this comment.
yes, given the FSI issue observed in hA2018, we want to Reweight from hA2018 to hA2025, the above code I think just check if the sample was generated with hA2018.
src/RwCalculators/GReWeighthA2025.h
Outdated
| Physics changes are considered separately for pions and nucleons. | ||
| Unitarity is explicitly conserved. | ||
| \author Jim Dobson <J.Dobson07 \at imperial.ac.uk> |
There was a problem hiding this comment.
Again, a review of the author list.
3 participants
added a new reweigh function for the new hA2025 FSI model.