Skip to content

Conversation

@vaivaswatha
Copy link
Contributor

Fixes #7433

@vaivaswatha vaivaswatha self-assigned this Oct 16, 2025
@vaivaswatha
Copy link
Contributor Author

I've also added a CLI flag to specify running the verifier after passes, that works quite similarly to the IR printing flag.

This flag isn't enabled in the CI though, yet. I'll do that as a separate PR (possibly after fixing issues, if any found, because of the verifier failing)

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 17, 2025

CodSpeed Performance Report

Merging #7457 will not alter performance

Comparing vaivaswatha/sroa_gep_fix (40c324f) with master (00b9d02)

Summary

✅ 25 untouched

@vaivaswatha vaivaswatha marked this pull request as ready for review October 17, 2025 11:12
@vaivaswatha vaivaswatha requested review from a team as code owners October 17, 2025 11:12
tritao
tritao previously approved these changes Oct 17, 2025
@vaivaswatha vaivaswatha requested a review from a team October 18, 2025 09:12
@vaivaswatha
Copy link
Contributor Author

This flag isn't enabled in the CI though, yet. I'll do that as a separate PR (possibly after fixing issues, if any found, because of the verifier failing)

I've enabled the flag now, and there aren't any failures, so we could have it as part of this PR itself.

@vaivaswatha vaivaswatha requested a review from tritao October 21, 2025 08:26
xunilrj
xunilrj previously approved these changes Oct 21, 2025
tritao
tritao previously approved these changes Oct 21, 2025
@vaivaswatha vaivaswatha enabled auto-merge (squash) October 21, 2025 11:00
@vaivaswatha vaivaswatha requested review from a team, ironcev and kayagokalp October 23, 2025 12:05
ironcev
ironcev previously approved these changes Oct 23, 2025
zees-dev
zees-dev previously approved these changes Oct 25, 2025
@vaivaswatha vaivaswatha dismissed stale reviews from zees-dev and ironcev via 3a2179a October 25, 2025 06:44
@vaivaswatha vaivaswatha requested review from a team, ironcev and zees-dev October 25, 2025 06:45
@vaivaswatha vaivaswatha merged commit f92c3f2 into master Oct 28, 2025
47 checks passed
@vaivaswatha vaivaswatha deleted the vaivaswatha/sroa_gep_fix branch October 28, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sroa is generating invalid IR

8 participants