Skip to content

Protect against passing i128::MIN to abs() which causes overflow #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Sep 25, 2024
Merged

Protect against passing i128::MIN to abs() which causes overflow #2241

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eaa2616
Protect against passing `i128::MIN` to `abs()` which causes overflow
Sep 23, 2024
5c0f1fd
Extract `safe_signed_abs()` function
Sep 23, 2024
056ba1e
Use `saturating_abs()` to protect against overflow
Sep 23, 2024
3047c7e
Test overflow fix via `update_l2_block_data()`
Sep 24, 2024
af9263d
Merge branch 'master' into 2210_prevent_overflow_in_abs
MitchTurner Sep 24, 2024
7359bd7
Remove the redundant test as `da_change` no longer panics
Sep 25, 2024
6188112
Merge remote-tracking branch 'upstream/2210_prevent_overflow_in_abs' …
Sep 25, 2024
faeefca
Merge branch 'master' into 2210_prevent_overflow_in_abs
rafal-ch Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/fuel-gas-price-algorithm/src/v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,7 +356,7 @@ impl AlgorithmUpdaterV1 {
.saturating_mul(upcast_percent)
.saturating_div(100)
.into();
let clamped_change = pd_change.abs().min(max_change);
let clamped_change = pd_change.saturating_abs().min(max_change);
Copy link
Member

@MitchTurner MitchTurner Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Nice find.

pd_change.signum().saturating_mul(clamped_change)
}

Expand Down