Move the Encoder/Encode/Decode traits from Storage to a different crate

[acerone85]

Context:

The storage crate defines three traits, Encoder Encode and Decode to encode and decode data that can be serialized/deserialized with Serde. See

fuel-core/crates/storage/src/codec.rs

Line 19 in f5240cb

pub trait Encoder {

In #2388, a similar approach is taken in the p2p service, where similar are defined and implemented. These traits serve the same purpose as the storage ones, but they have a slightly different interface. See

fuel-core/crates/services/p2p/src/codecs.rs

Line 15 in c564941

pub trait Encoder: Send {

.

Proposal:

• Move the Encoder, Encode and Decode trait from storage to a separate crate (maybe fuel_types?)
• Change the interface to be compatible with the traits used both in the P2P service and in the storage crate,
• Refactor P2P service and Storage crate to implement the new traits, and deprecate the old ones.

[xgreenx]

I don't see the reason to move mentioned traits from fuel-core-storage. Looks like a right place for them. If you need the same functionality, you can use fuel-core-storage crate directly, since you work with the storage types.

[acerone85]

no problems, it just looked to me that if we start using similar traits in other parts of the code that are not related to storage, (e.g. P2P service), then it might be worth moving them.

After #2388, I would still refactor the traits so that we don't have multiple definitions of Encoder/Encode/Decode with slightly different signatures.