se Vec<u8> for Encoder to avoid cloning

Author: acerone85

crates/services/p2p/src/codecs.rs

@@ -5,14 +5,11 @@ pub mod request_response;
 use crate::gossipsub::messages::GossipTopicTag;
 use libp2p::request_response as libp2p_request_response;
 
-use std::{
-    borrow::Cow,
-    io,
-};
+use std::io;
 
 pub trait Encoder: Send {
-    /// Returns the serialized object as a slice.
-    fn as_bytes(&self) -> Cow<[u8]>;
+    /// Returns the serialized object as a Vector.
+    fn as_vec(self) -> Vec<u8>;
 }
 
 /// The trait encodes the type to the bytes and passes it to the `Encoder`,
@@ -23,12 +20,10 @@ pub trait Encoder: Send {
 pub trait Encode<T: ?Sized> {
     type Error;
     /// The encoder type that stores serialized object.
-    type Encoder<'a>: Encoder
-    where
-        T: 'a;
+    type Encoder: Encoder;
 
     /// Encodes the object to the bytes and passes it to the `Encoder`.
-    fn encode<'a>(&self, t: &'a T) -> Result<Self::Encoder<'a>, Self::Error>;
+    fn encode(&self, t: &T) -> Result<Self::Encoder, Self::Error>;
 }
 
 /// The trait decodes the type from the bytes.
@@ -38,12 +33,9 @@ pub trait Decode<T> {
     fn decode(&self, bytes: &[u8]) -> Result<T, Self::Error>;
 }
 
-impl<'a> Encoder for Cow<'a, [u8]> {
-    fn as_bytes(&self) -> Cow<'_, [u8]> {
-        match self {
-            Cow::Borrowed(borrowed) => Cow::Borrowed(borrowed),
-            Cow::Owned(owned) => Cow::Borrowed(owned.as_ref()),
-        }
+impl Encoder for Vec<u8> {
+    fn as_vec(self) -> Vec<u8> {
+        self
     }
 }
 

crates/services/p2p/src/codecs/gossipsub.rs

@@ -32,7 +32,8 @@ where
     fn encode(&self, data: Self::RequestMessage) -> Result<Vec<u8>, io::Error> {
         match data {
             GossipsubBroadcastRequest::NewTx(tx) => {
-                Ok(self.codec.encode(&tx)?.as_bytes().into_owned())
+                let bytes = self.codec.encode(&tx)?;
+                Ok(bytes.as_vec())
             }
         }
     }

crates/services/p2p/src/codecs/postcard.rs

@@ -5,10 +5,7 @@ use super::{
     Encode,
 };
 
-use std::{
-    borrow::Cow,
-    io,
-};
+use std::io;
 
 #[derive(Clone, Default)]
 pub struct PostcardCodec;
@@ -39,13 +36,12 @@ impl<T> Encode<T> for PostcardCodec
 where
     T: ?Sized + serde::Serialize,
 {
-    type Encoder<'a> = Cow<'a, [u8]> where T: 'a;
+    type Encoder = Vec<u8>;
     type Error = io::Error;
 
-    fn encode<'a>(&self, value: &'a T) -> Result<Self::Encoder<'a>, Self::Error> {
-        Ok(Cow::Owned(postcard::to_allocvec(value).map_err(|e| {
-            io::Error::new(io::ErrorKind::Other, e.to_string())
-        })?))
+    fn encode<'a>(&self, value: &'a T) -> Result<Self::Encoder, Self::Error> {
+        Ok(postcard::to_allocvec(value)
+            .map_err(|e| io::Error::new(io::ErrorKind::Other, e.to_string()))?)
     }
 }
 

crates/services/p2p/src/codecs/request_response.rs

@@ -106,7 +106,7 @@ where
         T: futures::AsyncWrite + Unpin + Send,
     {
         let encoded_data = self.codec.encode(&req)?;
-        socket.write_all(&encoded_data.as_bytes()).await?;
+        socket.write_all(&encoded_data.as_vec()).await?;
         Ok(())
     }
 
@@ -123,12 +123,12 @@ where
             RequestResponseProtocol::V1 => {
                 let v1_response: V1ResponseMessage = res.into();
                 let res = self.codec.encode(&v1_response)?;
-                let res = res.as_bytes();
+                let res = res.as_vec();
                 socket.write_all(&res).await?;
             }
             RequestResponseProtocol::V2 => {
                 let res = self.codec.encode(&res)?;
-                let res = res.as_bytes();
+                let res = res.as_vec();
                 socket.write_all(&res).await?;
             }
         };