Use a new feature from the VM to get all required inputs in one dry run (#2840)

This change starts using the
FuelLabs/fuel-vm#918 feature for the
`asemble_tx` endpoint.

---------

Co-authored-by: Mårten Blankfors <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: Aaryamann Challani <[email protected]>

Author: 4 people

.changes/added/2840.md

@@ -0,0 +1,3 @@
+Added a new CLI arguments:
+- `assemble-tx-dry-run-limit` - The max number how many times script can be executed during `assemble_tx` GraphQL request. Default value is `3` times.
+- `assemble-tx-estimate-predicates-limit` - The max number how many times predicates can be estimated during `assemble_tx` GraphQL request. Default values is `10` times.

.changes/breaking/2840.md

@@ -0,0 +1,3 @@
+CLI argument `vm-backtrace` is deprecated and does nothing. It will be removed in a future version of `fuel-core`.
+The `extra_tx_checks` field was renamed into `forbid_fake_coins` that affects JSON based serialization/deserialization.
+Renamed `extra_tx_checks_default` field into `forbid_fake_coins_default`.

.changes/changed/2840.md

@@ -0,0 +1 @@
+Removed `log_backtrace` logic from the executor. It is not needed anymore with the existence of the local debugger for the transactions.

.changes/fixed/2840.md

@@ -0,0 +1 @@
+Fixed `fuel-core-client` receipt deserialization in the case if the `ContractId` is zero.

Cargo.lock

@@ -33,7 +33,6 @@ use fuel_core::{
         Config,
         DbType,
         RelayerConsensusConfig,
-        VMConfig,
     },
     state::rocks_db::{
         ColumnsPolicy,
@@ -197,6 +196,7 @@ pub struct Command {
 
     /// Enable logging of backtraces from vm errors
     #[arg(long = "vm-backtrace", env)]
+    #[deprecated]
     pub vm_backtrace: bool,
 
     /// Enable full utxo stateful validation
@@ -307,6 +307,7 @@ pub struct Command {
 
 impl Command {
     pub async fn get_config(self) -> anyhow::Result<Config> {
+        #[allow(deprecated)]
         let Command {
             service_name: name,
             max_database_cache_size,
@@ -319,7 +320,7 @@ impl Command {
             db_prune,
             snapshot,
             continue_on_error,
-            vm_backtrace,
+            vm_backtrace: _,
             debug,
             historical_execution,
             utxo_validation,
@@ -628,6 +629,9 @@ impl Command {
                 max_concurrent_queries: graphql.graphql_max_concurrent_queries,
                 request_body_bytes_limit: graphql.graphql_request_body_bytes_limit,
                 api_request_timeout: graphql.api_request_timeout.into(),
+                assemble_tx_dry_run_limit: graphql.assemble_tx_dry_run_limit,
+                assemble_tx_estimate_predicates_limit: graphql
+                    .assemble_tx_estimate_predicates_limit,
                 query_log_threshold_time: graphql.query_log_threshold_time.into(),
                 costs: Costs {
                     balance_query: graphql.costs.balance_query,
@@ -671,9 +675,6 @@ impl Command {
             executor_number_of_cores,
             block_production: trigger,
             predefined_blocks_path,
-            vm: VMConfig {
-                backtrace: vm_backtrace,
-            },
             txpool: TxPoolConfig {
                 max_txs_chain_count: tx_max_chain_count,
                 max_txs_ttl: tx_pool_ttl,

bin/fuel-core/src/cli/run.rs

@@ -66,6 +66,20 @@ pub struct GraphQLArgs {
     #[clap(long = "api-request-timeout", default_value = "30s", env)]
     pub api_request_timeout: humantime::Duration,
 
+    /// The max number how many times script can be executed
+    /// during `assemble_tx` GraphQL request.
+    #[clap(long = "assemble-tx-dry-run-limit", default_value = "3", env)]
+    pub assemble_tx_dry_run_limit: usize,
+
+    /// The max number how many times predicate can be estimated
+    /// during `assemble_tx` GraphQL request.
+    #[clap(
+        long = "assemble-tx-estimate-predicates-limit",
+        default_value = "10",
+        env
+    )]
+    pub assemble_tx_estimate_predicates_limit: usize,
+
     /// Maximum allowed block lag for GraphQL fuel block height requests.
     /// The client waits for the node to catch up if it's behind by no more blocks than
     /// this tolerance.

bin/fuel-core/src/cli/run/graphql.rs

@@ -72,11 +72,14 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
     fn try_from(schema: Receipt) -> Result<Self, Self::Error> {
         Ok(match schema.receipt_type {
             ReceiptType::Call => fuel_tx::Receipt::Call {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 to: schema
                     .to
-                    .ok_or_else(|| MissingField("to".to_string()))?
-                    .into(),
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 amount: schema
                     .amount
                     .ok_or_else(|| MissingField("amount".to_string()))?
@@ -107,7 +110,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::Return => fuel_tx::Receipt::Return {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 val: schema
                     .val
                     .ok_or_else(|| MissingField("val".to_string()))?
@@ -122,7 +128,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::ReturnData => fuel_tx::Receipt::ReturnData {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 ptr: schema
                     .ptr
                     .ok_or_else(|| MissingField("ptr".to_string()))?
@@ -151,7 +160,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::Panic => fuel_tx::Receipt::Panic {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 reason: schema
                     .reason
                     .ok_or_else(|| MissingField("reason".to_string()))?
@@ -167,7 +179,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                 contract_id: schema.contract_id.map(Into::into),
             },
             ReceiptType::Revert => fuel_tx::Receipt::Revert {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 ra: schema
                     .ra
                     .ok_or_else(|| MissingField("ra".to_string()))?
@@ -182,7 +197,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::Log => fuel_tx::Receipt::Log {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 ra: schema
                     .ra
                     .ok_or_else(|| MissingField("ra".to_string()))?
@@ -209,7 +227,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::LogData => fuel_tx::Receipt::LogData {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 ra: schema
                     .ra
                     .ok_or_else(|| MissingField("ra".to_string()))?
@@ -246,7 +267,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::Transfer => fuel_tx::Receipt::Transfer {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 to: schema
                     .to
                     .ok_or_else(|| MissingField("to".to_string()))?
@@ -269,7 +293,10 @@ impl TryFrom<Receipt> for fuel_tx::Receipt {
                     .into(),
             },
             ReceiptType::TransferOut => fuel_tx::Receipt::TransferOut {
-                id: schema.id.map(|id| id.into()).unwrap_or_default(),
+                id: schema
+                    .id
+                    .map(Into::into)
+                    .unwrap_or(fuel_tx::ContractId::zeroed()),
                 to: schema
                     .to_address
                     .ok_or_else(|| MissingField("to_address".to_string()))?

crates/client/src/client/schema/tx/transparent_receipt.rs

@@ -171,10 +171,8 @@ mod tests {
         /// The executor already has these parameters, and this field allows us
         /// to override the existing value.
         pub consensus_parameters: ConsensusParameters,
-        /// Print execution backtraces if transaction execution reverts.
-        pub backtrace: bool,
-        /// Default mode for utxo_validation
-        pub utxo_validation_default: bool,
+        /// Default mode for `forbid_fake_coins` in the executor.
+        pub forbid_fake_coins_default: bool,
     }
 
     #[derive(Clone, Debug)]
@@ -216,8 +214,7 @@ mod tests {
         config: Config,
     ) -> Executor<Database, DisabledRelayer> {
         let executor_config = fuel_core_upgradable_executor::config::Config {
-            backtrace: config.backtrace,
-            utxo_validation_default: config.utxo_validation_default,
+            forbid_fake_coins_default: config.forbid_fake_coins_default,
             native_executor_version: None,
             allow_historical_execution: true,
         };
@@ -825,7 +822,7 @@ mod tests {
             let mut validator = create_executor(
                 Default::default(),
                 Config {
-                    utxo_validation_default: false,
+                    forbid_fake_coins_default: false,
                     ..Default::default()
                 },
             );
@@ -1158,7 +1155,7 @@ mod tests {
 
         // setup executors with utxo-validation enabled
         let config = Config {
-            utxo_validation_default: true,
+            forbid_fake_coins_default: true,
             ..Default::default()
         };
         let producer = create_executor(Database::default(), config.clone());
@@ -1286,7 +1283,7 @@ mod tests {
         let mut executor = create_executor(
             Database::default(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -1354,7 +1351,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -1423,7 +1420,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -1472,7 +1469,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -1667,7 +1664,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: false,
+                forbid_fake_coins_default: false,
                 ..Default::default()
             },
         );
@@ -1722,7 +1719,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: false,
+                forbid_fake_coins_default: false,
                 ..Default::default()
             },
         );
@@ -1824,7 +1821,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: false,
+                forbid_fake_coins_default: false,
                 ..Default::default()
             },
         );
@@ -1930,9 +1927,8 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: false,
+                forbid_fake_coins_default: false,
                 consensus_parameters: consensus_parameters.clone(),
-                ..Default::default()
             },
         );
 
@@ -2091,7 +2087,7 @@ mod tests {
         let mut executor = create_executor(
             db.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -2380,7 +2376,7 @@ mod tests {
         create_executor(
             database,
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         )
@@ -2807,7 +2803,7 @@ mod tests {
         let mut executor = create_executor(
             database.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -2871,7 +2867,7 @@ mod tests {
         let mut executor = create_executor(
             database.clone(),
             Config {
-                utxo_validation_default: true,
+                forbid_fake_coins_default: true,
                 ..Default::default()
             },
         );
@@ -2893,9 +2889,8 @@ mod tests {
 
         let consensus_parameters = ConsensusParameters::default();
         let config = Config {
-            utxo_validation_default: true,
+            forbid_fake_coins_default: true,
             consensus_parameters: consensus_parameters.clone(),
-            ..Default::default()
         };
 
         let mut tx = TransactionBuilder::script(
@@ -3088,7 +3083,7 @@ mod tests {
             .finalize();
 
         let config = Config {
-            utxo_validation_default: false,
+            forbid_fake_coins_default: false,
             ..Default::default()
         };
         let (sender, mut receiver) = tokio::sync::mpsc::channel(2);
@@ -3152,7 +3147,7 @@ mod tests {
             .finalize();
 
         let config = Config {
-            utxo_validation_default: false,
+            forbid_fake_coins_default: false,
             ..Default::default()
         };
         let (sender, mut receiver) = tokio::sync::mpsc::channel(2);