Skip to content

Protected fields afterDelete fix #482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorisvaesen merged 3 commits into from
Mar 18, 2018
Merged

Protected fields afterDelete fix #482

jorisvaesen merged 3 commits into from
Mar 18, 2018

Conversation

@jorisvaesen
Copy link
Collaborator

@jorisvaesen jorisvaesen commented Mar 16, 2018

While introducing protected fields there was no test for the afterDelete method. When using a protected field, afterDelete should skip this value.

@davidyell
Copy link
Member

davidyell commented Mar 16, 2018

Seems good to me 👍

@jorisvaesen jorisvaesen merged commit d640151 into FriendsOfCake:master Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josegonzalez josegonzalez josegonzalez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jorisvaesen @davidyell @josegonzalez