added tests

added code to handle 'extra' data keys passed in categories

Author: Nils Stolpe

packages/victory-pie/src/helper-methods.ts

@@ -66,8 +66,10 @@ const sortDataByCategories = (props, data) => {
     const sorted: string[] = [];
     props.categories.x.forEach((category) => {
       const idx = data.findIndex(({ x }) => x === category);
-      const datum = data.splice(idx, 1)[0];
-      sorted.push(datum);
+      if (idx >= 0) {
+        const datum = data.splice(idx, 1)[0];
+        sorted.push(datum);
+      }
     });
     return [...sorted, ...data];
   }

packages/victory-pie/src/victory-pie.test.tsx

@@ -151,6 +151,30 @@ describe("components/victory-pie", () => {
       expect(xValues).toEqual(xValuesFromGivenData);
     });
 
+    it("renders data values sorted by categories prop", () => {
+      const { container } = render(
+        <VictoryPie categories={{ x: ["E", "A", "D", "C", "B"] }} />,
+      );
+
+      const xValues = Array.from(
+        container.querySelectorAll("text[id^=pie-labels] > tspan"),
+      ).map((slice) => slice.textContent);
+
+      expect(xValues).toEqual(["E", "A", "D", "C", "B"]);
+    });
+
+    it("renders data values sorted by categories prop, appending any data keys missing from categories and ignoring any categories values that are not valid data keys", () => {
+      const { container } = render(
+        <VictoryPie categories={{ x: ["E", "C", "B", "Z"] }} />,
+      );
+
+      const xValues = Array.from(
+        container.querySelectorAll("text[id^=pie-labels] > tspan"),
+      ).map((slice) => slice.textContent);
+
+      expect(xValues).toEqual(["E", "C", "B", "A", "D"]);
+    });
+
     it("renders data values sorted by sortKey prop", () => {
       const data = Helpers.range(9)
         .map((i) => ({ x: i, y: i }))