Skip to content

Commit 0e21843

Browse files
committed
Update to the latest version of pnpm in corepack
1 parent 31ae615 commit 0e21843

File tree

4 files changed

+13900
-10441
lines changed

4 files changed

+13900
-10441
lines changed

.github/actions/setup/action.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,7 @@ inputs:
99
runs:
1010
using: "composite"
1111
steps:
12-
- uses: pnpm/action-setup@v3
13-
with:
14-
version: 7
12+
- uses: pnpm/action-setup@v4
1513

1614
- name: Use Node.js
1715
uses: actions/setup-node@v4

CONTRIBUTING.md

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,7 @@ Victory is a monorepo built with [Wireit](https://github.com/google/wireit) and
2020
### Requirements
2121

2222
- [Node.js](https://nodejs.org/) 18 or higher.
23-
- [pnpm](https://pnpm.io/) 7.
24-
25-
> [!Note]
26-
> If you have a different pnpm version installed locally you can still use version 7 by prefixing the commands with `npx pnpm@7`.
27-
> For example, `npx pnpm@7 install`.
23+
- [pnpm](https://pnpm.io/) version specified by [corepack](https://github.com/nodejs/corepack) in the `package.json`.
2824

2925
### Setup
3026

@@ -35,11 +31,15 @@ $ git clone https://github.com/FormidableLabs/victory.git
3531
$ cd victory
3632
```
3733

34+
Enable corepack (if not already):
35+
36+
```sh
37+
$ corepack enable
38+
```
39+
3840
Use [pnpm](https://pnpm.io/) to install dependencies:
3941

4042
```sh
41-
# ... if you need pnpm
42-
$ npm install -g pnpm
4343
$ pnpm install
4444
```
4545

@@ -49,12 +49,15 @@ $ pnpm install
4949

5050
We have some dev servers available for a sample development environment.
5151

52+
> Note: The demo app is deprecated, all development should occur in storybook or the docs
53+
5254
```sh
53-
# TypeScript demo app
54-
$ pnpm start
55-
```
55+
# watch mode / HMR
56+
$ pnpm storybook:dev
5657

57-
These run appropriate file watchers, so you can just start developing source files and wait for the webpack dev server to pick up the new changes.
58+
# storybook standalone
59+
$ pnpm storybook:start
60+
```
5861

5962
### Running Docs locally
6063

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"url": "https://github.com/formidablelabs/victory/issues"
2020
},
2121
"homepage": "https://commerce.nearform.com/open-source/victory",
22-
"packageManager": "pnpm@7.33.7",
22+
"packageManager": "pnpm@9.13.0",
2323
"dependencies": {
2424
"clsx": "^2.1.1"
2525
},

0 commit comments

Comments
 (0)