From 08739ec2eb65164d5cc32fbf5f4da814fd161e32 Mon Sep 17 00:00:00 2001 From: Kristoffer Carlsson Date: Fri, 17 Nov 2023 11:51:30 +0100 Subject: [PATCH 1/2] remove show method for `TrackedArray` This method causes horrible invalidations and causes havoc in loading times and compilation time after Tracker.jl is loaded. For example, loading Enzyme.jl goes from 0.5 seconds to 22 seconds if Tracker.jl is loaded first. The printing of types should hopefully have been improved enough in https://github.com/JuliaLang/julia/pull/49795 that this is not needed. --- src/lib/array.jl | 5 ----- 1 file changed, 5 deletions(-) diff --git a/src/lib/array.jl b/src/lib/array.jl index c31f5bc..e4fcc00 100644 --- a/src/lib/array.jl +++ b/src/lib/array.jl @@ -41,11 +41,6 @@ Base.convert(T::Type{<:TrackedArray}, x::TrackedArray) = Base.convert(::Type{<:TrackedArray{T,N,A}}, x::AbstractArray) where {T,N,A} = TrackedArray(convert(A, x)) -Base.show(io::IO, t::Type{TrackedArray{T,N,A}}) where {T,N,A<:AbstractArray{T,N}} = - @isdefined(A) ? - print(io, "TrackedArray{…,$A}") : - invoke(show, Tuple{IO,DataType}, io, t) - function Base.summary(io::IO, x::TrackedArray) print(io, "Tracked ") summary(io, data(x)) From ca32ad3ee0f7d73ca50dbb96e6c151db4c86d037 Mon Sep 17 00:00:00 2001 From: Christopher Rackauckas Date: Fri, 17 Nov 2023 06:19:19 -0500 Subject: [PATCH 2/2] Update Project.toml --- Project.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Project.toml b/Project.toml index aa1a89e..c319b88 100644 --- a/Project.toml +++ b/Project.toml @@ -1,6 +1,6 @@ name = "Tracker" uuid = "9f7883ad-71c0-57eb-9f7f-b5c9e6d3789c" -version = "0.2.30" +version = "0.2.31" [deps] Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"