Skip to content

Commit 8a95d44

Browse files
authored
Upgrate from original repo (#1)
* Support modification of 'closable' setting while modal is open * [Dropdown] Allow ignoring of case when getting an item Currently get.item compares labels and values case sensitively. This can cause duplicates when `allowAdditions` is `true`. To prevent these duplicates get.item should be capable of comparing labels and values while ignoring case. However the current behaviour should be preserved by default. To achieve this a new setting is added called `ignoresCase`, which when `true` will disregard the casing of labels and string values when performing the comparision. * Fixed an issue where all child inputs of a icon input would recieve a right padding, not just the main input. This caused issues where a popup was attached to the icon input which caused all of the inputs inside of it to have an uneeded padding. * Update form.js Semantic-Org#4422 * Take content settings before attr title * Fix inverted dimmer text color The definition referenced the wrong variable. * Added `box-shadow` to the checkbox component’s `.toggle` variation * The width of inputs that are inside of a dropdown’s `.menu` should never be overridden * default 'prompt' message has mistakes in writing line 1266 - 1269 : correct 'must' to 'cannot', etc.. * Revert the changes and increase the selector’s specificity. * Fix horizontal scrollbar height, closes Semantic-Org#5728 * [Buttons] fix for active basic button text color always having a lower specificity due to !important * Add link to webpage at top of README I was looking for the link for way too long... * Fix issue with bottomPassed and topPassed * Added onChanging callback to accordion Because it's useful * Swap huge and big in menu.variables Semantic-Org#5899 * Swap bigWidth with hugeWidth in sizes Semantic-Org#5899 * [Flag] Add England Flag and Alias * Fix issue where dropdowns might animate outward two times on blur * Rlsnotes * Fix error which could cause popup to use wrong offset context when specifying popup manually * Rlsnotes popup * Fix for Semantic-Org#5713 [Form Validation] regression: get values with radio returns true or false Semantic-Org#5713 * Use @background value for arrow background color * Changed gulp-clone version (Fixes Semantic-Org#6067) New update to gulp-clone breaks CSS build task * Added .idea for PhpStorm and WebStorm * Made a complete port of FA5 with all new icons Added sui aliases for current icons Added new aliases for old icons which no longer exist to help with compatibility * Updated YouTube colour Updated the YouTube colour to the new red. https://www.youtube.com/intl/en-GB/yt/about/brand-resources/ * Fix Semantic-Org#5366, Semantic-Org#5975, taken from @dannyBies * Semantic-Org#5366, Semantic-Org#5975 - Fixes open rightward/leftward incorrectly adjusting to scroll context * Update gulp-clone dep with issue Semantic-Org#6067 Semantic-Org#6089 * Update rlsnotes * Semantic-Org#5366, Semantic-Org#5975 - Fixes issue with offset not available on window * Update rlsnotes * Semantic-Org#6043 Semantic-Org#5713 code formatting * Rlsnotes Semantic-Org#6043, Semantic-Org#5713, 6067 * Adds coupling for ribbon label with reveal Semantic-Org#5681 * Release notes Semantic-Org#5681 * Fix issue with scrolling modal and allowMultiple Semantic-Org#2423 * Rlsnotes Semantic-Org#5097 * Rlsnotes Semantic-Org#5530 * Rlsnotes * Add coupling for lists inside menus, fix box shadow showing as border Semantic-Org#5603 * Add additional weight to link list states Semantic-Org#5603 * Rlsnotes Semantic-Org#5603 * Revert "[Dropdown] Allow ignoring of case when getting an item" * Semantic-Org#3432 implement matching user addition case * Semantic-Org#3432 Simplifies setting name (derp), adds default to false * Add issue links * Update dist to 2.2.14 * Regen package-lock * Update rlsnotes for 2.2.14 * Typos in release notes * Fix element structure Change end tag from </div> to </h4> to correctly match opening tag * Remove href attribute from div element * Remove closing </div> element for which no opening elements exists * Updated to 2.2.14 file which fixes the gulp-clone bug * Fixed all broken icons, changed some names and updated to 5.0.6 Added `elementor` icon Added `youtube-square` icon Added `window-minimize` icon Added `chess` icon Added `chess bishop` icon Added `chess board` icon Added `chess king` icon Added `chess knight` icon Added `chess pawn` icon Added `chess queen` icon Added `chess rock` icon Added `square full` icon Added `baseball ball` icon Added `basketball ball` icon Added `bowling ball` icon Added `football ball` icon Added `futbol` icon Added `futbol outline` icon Added `golf ball` icon Added `hocky puck` icon Added `quidditch` icon Added `table tennis` icon Added `volleyball ball` icon Fixed `cloud download alternate` icon Fixed `cloud upload alternate` icon Fixed `external link square alternate` icon Fixed `pencil alternate` icon Fixed `window close` icon Fixed `window restore outline` icon Fixed `images` icon Fixed `500px` icon Fixed `accessible icon` icon Fixed `accusoft` icon Fixed `app store ios` icon Fixed `apper` icon Fixed `asymmetrik` icon Fixed `audible` icon Fixed `avianex` icon Fixed `aws` icon Fixed `bimobject` icon Fixed `bitcoin` icon Fixed `centercode` icon Fixed `cloudscale` icon Fixed `cloudsmith` icon Fixed `cloudversify` icon Fixed `cpanel` icon Fixed `digital ocean` icon Fixed `discord` icon Fixed `discourse` icon Fixed `dochub` icon Fixed `docker` icon Fixed `draft2digital` icon Fixed `dribbble square` icon Fixed `dyalog` icon Fixed `fly` icon Fixed `uber` icon Fixed `uikit` icon Fixed `uniregistry` icon Fixed `untappd` icon Fixed `ussunnah` icon Fixed `vaadin` icon Fixed `viber` icon Fixed `wordpress simple` icon Fixed `xbox` icon Fixed `yandex international` icon Fixed `yandex` icon Renamed `list ol` to `ordered list` Renamed `list ul` to `unordered list` Renamed `user md` to `user doctor` Renamed `cc amex` to `credit card american express` Renamed `cc *` to `credit card *` Renamed `red river` to `redriver` * Add missing comma: makes 9 global vars local * Update README.md * Fix bug with autofocus modifying focus of modal fields * Correctly calculate offset when popup is in a different positioning context * Add arrow centering on small popups * Add centered dimmers and modals * Fixes alignment of dimmer * Updates to ui search to allow local category search, and responsive name width * Semantic-Org#6085 dedupe icons from FA5 port * Rlsnotes on icons * Username typo * Rlsnotes Semantic-Org#6127 * Rlsnotes Semantic-Org#6059 * Add font weight global variables * Thanks Semantic-Org#6167 * Thanks Semantic-Org#5902 * Implements Semantic-Org#4458 * Thanks Semantic-Org#4614 * Thanks Semantic-Org#4614 * Revert "'on: change' causes error prompts to appear when blurring field " * Semantic-Org#4423 in next * Semantic-Org#4423 Thx * Thanks Semantic-Org#4631 * Semantic-Org#3396 modal close * Fix transitions on ui images > .image * Adds glow transition * Input selectors now require child selector to avoid inheritance issues Semantic-Org#4157 * rlsnotes * Fix eventNamespace in Semantic-Org#3396 * Fix modal flex issue in IE11 * Add zoom transition * Add mobile styles for search * Add PR links to rlsnotes * Rlsnotes Semantic-Org#6167 * Semantic-Org#5892 - Add onChanging callback * Tighten scrolling margin * Build 2.3.0 * Update README.md Remove forum from readme * Update README.md * Update README.md Remove project talk * Update README.md * Update README.md * Update README.md * Update RELEASE-NOTES.md * Create stale.yml * chore(stale.yml): update exempt labels * Add issue templates * Update ISSUE_TEMPLATE.md * Update ISSUE_TEMPLATE.md * Update ISSUE_TEMPLATE.md * Update ISSUE_TEMPLATE.md * Update ISSUE_TEMPLATE.md * Update ISSUE_TEMPLATE.md
1 parent 796d2f6 commit 8a95d44

File tree

214 files changed

+15645
-13574
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

214 files changed

+15645
-13574
lines changed

.github/ISSUE_TEMPLATE.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
✖ USAGE QUESTIONS → Use these dedicated resources:
2+
Docs - http://www.semantic-ui.com
3+
Chat - https://gitter.im/Semantic-Org/Semantic-UI
4+
SO - https://stackoverflow.com/questions/tagged/semantic-ui?sort=votes
5+
6+
✔ Enhancements → Be specific. Assume backwards compatibility is a necessity. Suggest implementation when possible.
7+
✔ BUGS → ❤❤❤. Keep in mind some bugs may not be immediately fixable due to backwards compatibility or CSS limitations.
8+
9+
### Title (Put in field above)
10+
Use the format: [Component] Component Should Do X
11+
i.e. [Checkbox] onChange Should Fire When Update Triggered via DOM
12+
13+
### Steps
14+
15+
### Expected Result
16+
17+
### Actual Result
18+
19+
### Version
20+
x.y.z
21+
22+
### Testcase
23+
[Fork, update, and replace to show the bug]:
24+
https://jsfiddle.net/ca0rovs3/

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
✖ Multiple features in one PR
2+
✖ New Components Unless Previously Discussed with Maintainers (Consider creating separate repo, I'll link out to you)
3+
4+
✔ Add comments to complex/confusing code in "code" view of PR
5+
✔ BUGS → This form is required:
6+
✔ Enhancements → Only specific enhancements with detailed descriptions.
7+
8+
### Issue Titles
9+
10+
Use the format: [Component] Adds Support for Thing
11+
12+
For example: [Build Tools] Adds Source Map Support
13+
Or: [Button] Fixes Inheritance for Red Basic Active State
14+
15+
### Closed Issues
16+
#222 #333 #444
17+
18+
### Description
19+
20+
### Testcase
21+
22+
[Show before with this fiddle]
23+
https://jsfiddle.net/ca0rovs3/
24+
25+
[Consider showing "fixed" case with your fiddle]()
26+
27+
You can link to your JS using https://rawgit.com/
28+

.github/stale.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Number of days of inactivity before an issue becomes stale
2+
daysUntilStale: 90
3+
4+
# Number of days of inactivity before a stale issue is closed
5+
daysUntilClose: 30
6+
7+
# Issues with these labels will never be considered stale
8+
exemptLabels:
9+
- Confirmed Bug
10+
- Needs Milestone
11+
12+
# Label to use when marking an issue as stale
13+
staleLabel: stale
14+
15+
# Comment to post when marking an issue as stale. Set to `false` to disable
16+
markComment: >
17+
This issue has been automatically marked as stale because it has not had
18+
recent activity. It will be closed in 30 days if no further activity occurs.
19+
Thank you for your contributions.
20+
21+
# Comment to post when closing a stale issue. Set to `false` to disable
22+
closeComment: false

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,4 @@ nbproject
3434
*.sublime-project
3535
*.sublime-workspace
3636
.build*
37+
.idea

README.md

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
[![CDNJS](https://img.shields.io/cdnjs/v/semantic-ui.svg)](https://cdnjs.com/libraries/semantic-ui/)
88

9-
Semantic is a UI framework designed for theming.
9+
[Semantic](http://www.semantic-ui.com) is a UI framework designed for theming.
1010

1111
Key Features
1212
* 50+ UI elements
@@ -17,15 +17,15 @@ Key Features
1717

1818
Semantic allows developers to build beautiful websites fast, with **concise HTML**, **intuitive javascript**, and **simplified debugging**, helping make front-end development a delightful experience. Semantic is responsively designed allowing your website to scale on multiple devices. Semantic is production ready and partnered with frameworks such as **React**, **Angular**, **Meteor**, and **Ember**, which means you can integrate it with any of these frameworks to organize your UI layer alongside your application logic.
1919

20-
## 2.2 Release
20+
## 2.3.0 Release (Feb 20th, 2018)
2121

22-
Semantic UI `2.2` is now available (June 2016). Read up on [what's new](http://www.semantic-ui.com/introduction/new.html) in the docs.
22+
Semantic UI `2.3` is now available. Read up on [what's new](http://www.semantic-ui.com/introduction/new.html) in the docs.
2323

2424
Migration info from `1.x` can be found in the [2.0 release notes](https://github.com/Semantic-Org/Semantic-UI/blob/master/RELEASE-NOTES.md#version-200---march-xx-2015)
2525

2626
## User Support
2727

28-
Please help us keep the issue tracker organized. For all questions that do not include a specific [JSFiddle test case](https://jsfiddle.net/ca0rovs3/) (bug reports), or feature request please use our user forums at [http://forums.semantic-ui.com](http://forums.semantic-ui.com) to discuss.
28+
Please help us keep the issue tracker organized. For technical questions that do not include a specific [JSFiddle test case](https://jsfiddle.net/ca0rovs3/) (bug reports), or feature request please use [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) to find a solution.
2929

3030
Visit our [contributing guide](https://github.com/Semantic-Org/Semantic-UI/blob/master/CONTRIBUTING.md) for more on what should be posted to GitHub Issues.
3131

@@ -36,8 +36,7 @@ Visit our [contributing guide](https://github.com/Semantic-Org/Semantic-UI/blob/
3636
npm install semantic-ui # Use themes, import build/watch tasks into your own gulpfile.
3737
```
3838

39-
Semantic UI includes an interactive installer to help setup your project
40-
![Getting Started](https://dl.dropboxusercontent.com/u/2657007/install.gif)
39+
Semantic UI includes an interactive installer to help setup your project.
4140

4241
* For more details on setup visit our [getting started guide](http://semantic-ui.com/introduction/getting-started.html).
4342
* To learn more about theming please read our [theming guide](http://www.semantic-ui.com/usage/theming.html)
@@ -69,7 +68,7 @@ Although some components will work in IE9, [grids](http://semantic-ui.com/collec
6968
## Community
7069

7170
#### Getting Help
72-
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom](https://gitter.im/Semantic-Org/Semantic-UI), [Semantic UI forums](http://forums.semantic-ui.com) or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
71+
Please **do not post** usage questions to GitHub Issues. For these types of questions use our [Gitter chatroom] or [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui).
7372

7473
#### Submitting Bugs and Enhancements
7574
[GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues) is for suggesting enhancements and reporting bugs. Before submiting a bug make sure you do the following:
@@ -94,7 +93,6 @@ Resource | Description
9493
--- | --- |
9594
Bugs & Feature Requests | All bug submission **require** a link to a test case, and a set of steps to reproduce the issue. You can make a test case by forking this [JSFiddle](https://jsfiddle.net/ca0rovs3/), then submit your [bug report on GitHub Issues](https://github.com/Semantic-Org/Semantic-UI/issues)
9695
Live Chat | Join our [Gitter.im Room](https://gitter.im/Semantic-Org/Semantic-UI)
97-
Message Board | [ProjectTalk Board](http://www.projecttalk.io/boards/Semantic-Org%2FSemantic-UI)
9896
Newsletter Updates | Sign up for updates at [semantic-ui.com](http://www.semantic-ui.com)
9997
Additional Resources | Submit a question on [StackOverflow](http://stackoverflow.com/questions/tagged/semantic-ui) or ask our [Google Group](https://groups.google.com/forum/#!forum/semantic-ui)
10098

RELEASE-NOTES.md

Lines changed: 98 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,107 @@
11
## RELEASE NOTES
22

3+
### Version 2.3.0 - Feb 20, 2018
4+
5+
**Major Enhancements**
6+
- **Icons** - Font Awesome 5 is now included in Semantic UI **Thanks @hammy2899** [#6085](https://github.com/Semantic-Org/Semantic-UI/issues/6085)
7+
8+
- **Search** - Category search can now work with local search by adding a `category` property to any result and specifying `type: 'category'`
9+
10+
```javascript
11+
var categoryContent = [
12+
{ category: 'South America', title: 'Brazil' },
13+
{ category: 'South America', title: 'Peru' },
14+
{ category: 'North America', title: 'Canada' },
15+
{ category: 'Asia', title: 'South Korea' },
16+
{ category: 'Asia', title: 'Japan' },
17+
{ category: 'Asia', title: 'China' },
18+
{ category: 'Europe', title: 'Denmark' },
19+
{ category: 'Europe', title: 'England' },
20+
{ category: 'Europe', title: 'France' },
21+
{ category: 'Europe', title: 'Germany' },
22+
{ category: 'Africa', title: 'Ethiopia' },
23+
{ category: 'Africa', title: 'Nigeria' },
24+
{ category: 'Africa', title: 'Zimbabwe' },
25+
];
26+
$('.ui.search')
27+
.search({
28+
type: 'category',
29+
source: categoryContent
30+
})
31+
;
32+
```
33+
34+
- **Popup** - Popup can now position elements correctly even when they have a different offset context than their activating element. Like in [this example](https://jsfiddle.net/g853mc03/).
35+
36+
- **Popup** - Popup will now align the center of the arrow (not the edge of the popup) when it would be reasonable (up to 2x arrow's offset from edge). [See this explanation](http://oi66.tinypic.com/2zr2ckk.jpg)
37+
38+
To preserve functionality `movePopup` default has remained as `true` (moving the popup to the same offset context), however now setting `movePopup: false` should now always position correctly. Be sure to use `movePopup: true` to avoid issues with `ui popup` inside `menu`, `input` or other places where it may inherit rules from its activating element or its context.
39+
40+
- **Transition** - Adds new `glow` transition for highlighting an element on the page, and `zoom` animation for scaling elements without opacity tween.
41+
42+
- **Modal** - Modal has been rewritten to use `flexbox`. No need to call `refresh()` to recalculate vertical centering.
43+
44+
- **Modal** - Modals now have a setting `centered` which can be used to disable vertical centering. This can be useful for modals with content that changes dynamically to prevent content from jumping in position.
45+
46+
**Minor Enhancements**
47+
- **Theming** - Added global variables for reassigning `normal` and `bold` font weights for custom font stacks. **Thanks @jaridmargolin** [#6167](https://github.com/Semantic-Org/Semantic-UI/issues/6167)
48+
- **Search** - Category results now has `exact` setting matching dropdown for `fullTextSearch` preventing fuzzy search
49+
- **Search** - Category results will now responsively adjust `title` row if titles are long instead of forcing a title width
50+
- **Dimmer** - Dimmers now have centered content with a single wrapping `content` element.
51+
- **Modal** - You can now modify `closable` setting after init **Thanks @mdehoog** [#3396](https://github.com/Semantic-Org/Semantic-UI/issues/3396)
52+
- **Accordion** - Added `onChanging` callback for accordion that occurs before animation in both directions **Thanks @GammeGames** [#5892](https://github.com/Semantic-Org/Semantic-UI/pull/5892)
53+
54+
**Tiny Enhancements**
55+
- **Popup** - `arrowBackground` now inherits from `background` [#6059](https://github.com/Semantic-Org/Semantic-UI/issues/6059) **Thanks @devsli**
56+
- **Popup** - Adds new variable `headerFontWeight`
57+
- **Search** - Search now has responsive styles for mobile to prevent results being large than page width.
58+
59+
**Bugs**
60+
- **Modal** - Modal `autofocus` setting now checks to see if currently focused element is in modal, avoiding issues where focus could be set in `onVisible` or `onShow`
61+
- **Menu** - Fixes `big` and `huge` sizes being swapped in menu **Thanks @jeremy091** [#5902](https://github.com/Semantic-Org/Semantic-UI/issues/5902) [#5899](https://github.com/Semantic-Org/Semantic-UI/issues/5899)
62+
- **Table** - Fixes tr not having correct border on first row when using multiple `tbody` **Thanks @Mlukman** [#4458](https://github.com/Semantic-Org/Semantic-UI/issues/4458)
63+
- **Popup** - Popup will now use `content` specified in settings before `title` attribute [#4614](https://github.com/Semantic-Org/Semantic-UI/issues/4614) **Thanks @aaronbhansen**
64+
- **Form Validation** - Fixes bug where `on: 'change'` would still show validation prompts on `blur` when using `inline: true` [#4423](https://github.com/Semantic-Org/Semantic-UI/issues/4423) **Thanks @avalanche1**
65+
- **Dimmer** - Fixes issue with `inverted dimmer` with `content` having wrong text color **Thanks @rijk** [#4631](https://github.com/Semantic-Org/Semantic-UI/issues/4631)
66+
- **Images / Transition** - Fixed issue where `ui images` would show nested images with `transition hidden` as block (Fixes sequential img animation demo in docs)
67+
68+
**Doc Updates**
69+
- **Icons** - Icon documentation now has a search that will copy the relevent icon html to clipboard
70+
- **Icons** - Icon documentation now lists publicly all icon aliases
71+
72+
**Doc Bugs**
73+
- **UI Examples** - Fixe some improper html in UI examples included with repo [#6127](https://github.com/Semantic-Org/Semantic-UI/issues/6127) **Thanks @perdian**
74+
- **Admin** - Fixes bug in admin script that caused leaked global vars **Thanks @esbena** [#6136](https://github.com/Semantic-Org/Semantic-UI/issues/6136)
75+
76+
### Version 2.2.14 - Jan 29, 2018
77+
78+
**Critical Bugs**
79+
- **Form** - Fixes issue where radio checkbox would not return correct value from `get values` **Thanks @tincdev** [#5713](https://github.com/Semantic-Org/Semantic-UI/issues/5713) [#6043](https://github.com/Semantic-Org/Semantic-UI/issues/6043)
80+
- **Modal** - Fixes issue where an oversized modal would appear behind an existing modal when using `allowMultiple: true` and a second modal that is larger than the screen height. [#2423](https://github.com/Semantic-Org/Semantic-UI/issues/2423)
81+
82+
**Enhancements**
83+
- **Button** - YouTube's red color now matches their current brand guidelines **Thanks @hammy2899** [#6110](https://github.com/Semantic-Org/Semantic-UI/issues/6110)
84+
- **Flag** - Adds missing flag for England **Thanks @zyzniewski** [#5944](https://github.com/Semantic-Org/Semantic-UI/issues/5944)
85+
- **Reveal** - `ribbon label` can now work with `reveal` [#5681](https://github.com/Semantic-Org/Semantic-UI/issues/5681)
86+
- **Dropdown** - Added new setting `ignoreCase` (defaults to false) that will prevent values from being added that match existing values (case insensitive). This is particularly useful when using allowAdditions for tagging to not allow case insensitive matches.
87+
- **Site** - Site theme now includes `@customScrollbarHeight` and specifies a default horizontal scrollbar height **Thanks @jayphelps** [#5749](https://github.com/Semantic-Org/Semantic-UI/issues/5749)
88+
89+
**Bugs**
90+
- **Checkbox** - Fixes issue where `toggle checkbox` box shadow was missing **Thanks @banandrew** [#5096](https://github.com/Semantic-Org/Semantic-UI/issues/5096)
91+
- **Dropdown** - Fixed issue where dropdowns could incorrectly open upward and leftward opening when using `context` setting due to an incorrect offset calculation. **Thanks @dannyBies** [#5974](https://github.com/Semantic-Org/Semantic-UI/issues/5974) [#5366](https://github.com/Semantic-Org/Semantic-UI/issues/5366)
92+
- **Form Validation** - Fixed issue where default prompts for `contain` and `doesntContain` rules were swapped. **Thanks @xiongyu-git** [#5530](https://github.com/Semantic-Org/Semantic-UI/issues/5530)
93+
- **Visibility** - Fixes issue where `bottomPassed` and `topPassed` would not fire under some conditions
94+
- **Dropdown** - Fixes issue where dropdowns might accidentally animate closed two times when quickly tabbing through fields
95+
- **Popup** - Fixed an error which could cause popup not to move to right offset context when using a different target setting.
96+
- **Dropdown** - Fixed issue where using `ui input` in a dropdown menu could cause the input to be too wide in some cases **Thanks @banandrew** [#5085](https://github.com/Semantic-Org/Semantic-UI/issues/5085)
97+
- **Menu / Popup** - Fixed issue where `inverted menu` rules would cause popup inside a menu to have incorrect link styling in `link list` **Thanks @banandrew** [#5585](https://github.com/Semantic-Org/Semantic-UI/issues/5585) [#5603](https://github.com/Semantic-Org/Semantic-UI/issues/5603)
98+
- **CSS Build** - Fixed issue where package `gulp-clone` was only set to use > `1.0` causing issues with gulp builds due to upstream error [#6067](https://github.com/Semantic-Org/Semantic-UI/issues/6067)
99+
3100
### Version 2.2.13 - Aug 07, 2017
4101

5102
**Hotfix** (2)
6103
- **Install** - Some interactive install script issues may be fixed. Forked `gulp-prompt` plugin to allow for updated `inquirer` version
7-
- **Build Tools** - Fixes typo causing fix for build tools to fail [#5391](https://github.com/Semantic-Org/Semantic-UI/issues/5391)
104+
- **Build Tools** - Fixes typo causing fix for build tools to fail [#5391](https://github.com/Semantic-Org/Semantic-UI/issues/5391)
8105

9106
### Version 2.2.12 - Aug 07, 2017
10107

dist/components/accordion.css

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* # Semantic UI 2.2.12 - Accordion
2+
* # Semantic UI 2.3.0 - Accordion
33
* http://github.com/semantic-org/semantic-ui/
44
*
55
*
@@ -127,7 +127,8 @@
127127
.ui.styled.accordion .accordion {
128128
border-radius: 0.28571429rem;
129129
background: #FFFFFF;
130-
box-shadow: 0px 1px 2px 0 rgba(34, 36, 38, 0.15), 0px 0px 0px 1px rgba(34, 36, 38, 0.15);
130+
-webkit-box-shadow: 0px 1px 2px 0 rgba(34, 36, 38, 0.15), 0px 0px 0px 1px rgba(34, 36, 38, 0.15);
131+
box-shadow: 0px 1px 2px 0 rgba(34, 36, 38, 0.15), 0px 0px 0px 1px rgba(34, 36, 38, 0.15);
131132
}
132133
.ui.styled.accordion .title,
133134
.ui.styled.accordion .accordion .title {

dist/components/accordion.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/*!
2-
* # Semantic UI 2.2.12 - Accordion
2+
* # Semantic UI 2.3.0 - Accordion
33
* http://github.com/semantic-org/semantic-ui/
44
*
55
*
@@ -169,6 +169,7 @@ $.fn.accordion = function(parameters) {
169169
}
170170
module.debug('Opening accordion content', $activeTitle);
171171
settings.onOpening.call($activeContent);
172+
settings.onChanging.call($activeContent);
172173
if(settings.exclusive) {
173174
module.closeOthers.call($activeTitle);
174175
}
@@ -232,6 +233,7 @@ $.fn.accordion = function(parameters) {
232233
if((isActive || isOpening) && !isClosing) {
233234
module.debug('Closing accordion content', $activeContent);
234235
settings.onClosing.call($activeContent);
236+
settings.onChanging.call($activeContent);
235237
$activeTitle
236238
.removeClass(className.active)
237239
;
@@ -574,10 +576,11 @@ $.fn.accordion.settings = {
574576
duration : 350, // duration of animation
575577
easing : 'easeOutQuad', // easing equation for animation
576578

577-
578579
onOpening : function(){}, // callback before open animation
579-
onOpen : function(){}, // callback after open animation
580580
onClosing : function(){}, // callback before closing animation
581+
onChanging : function(){}, // callback before closing or opening animation
582+
583+
onOpen : function(){}, // callback after open animation
581584
onClose : function(){}, // callback after closing animation
582585
onChange : function(){}, // callback after closing or opening animation
583586

0 commit comments

Comments
 (0)