Skip to content

Fixed problem in StdDelegatingSerializer#serializeWithType where final serializer lookup was done on the pre-converted value when _delegateSerializer was null. #4749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Fixed problem in StdDelegatingSerializer#serializeWithType where final serializer lookup was done on the pre-converted value when _delegateSerializer was null. #4749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
92b4511
Fixed serializer fetching for delegateValue
k163377 Oct 13, 2024
970c3c4
Update release notes wrt #4749
k163377 Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions release-notes/CREDITS-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1840,3 +1840,7 @@ Rikkarth (rikkarth@github)
Maxim Valeev (@MaximValeev)
* Reported #4508: Deserialized JsonAnySetter field in Kotlin data class is null
(2.18.1)

wrongwrong (@k163377)
* Contributed #4749: Fixed problem in StdDelegatingSerializer#serializeWithType where final serializer lookup was done
on the pre-converted value when _delegateSerializer was null
3 changes: 3 additions & 0 deletions release-notes/VERSION-2.x
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Project: jackson-databind

2.18.1 (WIP-2024)

#4749: Fixed a problem with `StdDelegatingSerializer#serializeWithType` looking up the serializer
with the wrong argument
(fix by wrongwrong)
#4508: Deserialized JsonAnySetter field in Kotlin data class is null
(reported by @MaximValeev)
(fix by Joo-Hyuk K)
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/fasterxml/jackson/databind/ser/std/StdDelegatingSerializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public void serializeWithType(Object value, JsonGenerator gen, SerializerProvide
}
JsonSerializer<Object> ser = _delegateSerializer;
if (ser == null) {
ser = _findSerializer(value, provider);
ser = _findSerializer(delegateValue, provider);
}
ser.serializeWithType(delegateValue, gen, provider, typeSer);
}
Expand Down