Merged
Conversation
Reonu
approved these changes
Nov 15, 2025
Contributor
There was a problem hiding this comment.
- Importing link is fine
- Exporting transition actors is fixed after you latest commit
- Importing lon lon ranch and jabu jabu gives the expected result
- Quick import partially works like you mentioned, it's not more broken than before so it's ok
- Importing a wrong scene no longer creates a folder which is good (???????)
- Importing lights in recent decomp seems ok
seems ok
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses random issues:
Noneand also won't parent to the front room, it will also explicitely say that transition actor has an issue, since this only affects 2 scenes for 3 actors in total I think this is completely fine, the doors are unused anyway since they're all in cutscene setups0x0400(or1 << 10) there should be an index, which should be the that transition actor's position in the transition actor list, should be harmless for unmodified door actors (seefunc_800C0D34inz_play.c, it's used for "OnePointDemo" cutscenes)