Skip to content

[OoT] Link import fails to import eye and mouth textures as flipbook #404

@Dragorn421

Description

@Dragorn421

So the eye/mouth textures are missing and Link has a rgb(0,0,0) face

After investigating this is because zeldaret/oot#1928 changed e.g. void* sEyeTextures[][8] to void* sEyeTextures[][PLAYER_EYES_MAX] (8 -> PLAYER_EYES_MAX).
But the regex in fast64 for finding these arrays (here

r"void\s*\*\s*([0-9a-zA-Z\_]*)\s*\[\s*\]\s*\[[0-9a-fA-Fx]*\]\s*=\s*\{(.*?)\}\s*;",
) assumes a decimal or hexadecimal length, so it "didn't see" those arrays anymore

changing the regex to also allow basically a C identifier like [0-9a-zA-Z_] fixes this
full fixed regex void\s*\*\s*([0-9a-zA-Z\_]*)\s*\[\s*\]\s*\[[0-9a-zA-Z_]*\]\s*=\s*\{(.*?)\}\s*;
https://regex101.com/r/y5timv/1

linkW

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingootHas to do with the Ocarina of Time 64 side

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions