Skip to content

Conversation

@sylv256
Copy link
Member

@sylv256 sylv256 commented Dec 10, 2025

Description

This Pull Request ports the Fabric Rendering API, Fabric Renderer Indigo, and Fabric Model Loading API to 1.21.11.

Changes

  • QuadView, MutableQuadView, and QuadEmitter now store atlas data as an enum QuadAtlas.
  • Due to the block/item atlas split, items rendered using modded quads may use either the block atlas or the item atlas, but each item layer is limited to using one atlas. This is no longer the case.
  • Indigo now stores a QuadAtlas field in quad headers.
  • The toVanilla and fromVanilla methods in QuadView, MutableQuadView, and QuadEmitter have been removed due Mojang using unpacked vertex data in BakedQuad.
  • As a side effect, BakedQuad no longer stores FRAPI data such as normals, color, or atlas!
  • VANILLA_VERTEX_STRIDE and VANILLA_QUAD_STRIDE in QuadView have been removed.
  • ModelBakeSettingsHelper#asQuadTransform now takes a QuadAtlasSpriteGetter in place of a SpriteFinder to ensure that both item and block quad atlases have associated sprite finders.
  • The QuadAtlasSpriteGetter functional interface has been added for ModelBakeSettingsHelper#asQuadTransform.
  • BlockRenderDispatcherAccessor#getBlockEntityModelsGetter has been removed in favor of ModelManager#specialBlockModelRenderer.
  • The fabric-model-loading-api-v1, fabric-renderer-api-v1, and fabric-renderer-indigo modules have been re-enabled.
  • Added FabricLayerRenderState#setRenderTypeGetter and ItemRenderTypeGetter to allow implementations of ItemModel to use both the block and item atlases on the same layer.

@CallMeEchoCodes CallMeEchoCodes added area: rendering port Porting existing code to a different version labels Dec 10, 2025
Copy link
Member Author

@sylv256 sylv256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@sylv256 sylv256 marked this pull request as ready for review December 11, 2025 23:16
@PepperCode1 PepperCode1 self-requested a review December 11, 2025 23:38
@modmuss50 modmuss50 added the priority: high High priority PRs that need review and work now. Review these first. label Dec 12, 2025
Copy link
Member Author

@sylv256 sylv256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@modmuss50 modmuss50 added the status: merge me please Pull requests that are ready to merge label Dec 17, 2025
@modmuss50 modmuss50 merged commit f4ffd2e into FabricMC:1.21.11 Dec 17, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: rendering port Porting existing code to a different version priority: high High priority PRs that need review and work now. Review these first. status: merge me please Pull requests that are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants