-
Notifications
You must be signed in to change notification settings - Fork 497
[FRAPI] Port to 1.21.11 #5038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[FRAPI] Port to 1.21.11 #5038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptive FIXME" This reverts commit 7c8252b.
… the mesh uses the block atlas
sylv256
commented
Dec 11, 2025
Member
Author
sylv256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far
PepperCode1
approved these changes
Dec 17, 2025
sylv256
commented
Dec 17, 2025
Member
Author
sylv256
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
modmuss50
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: rendering
port
Porting existing code to a different version
priority: high
High priority PRs that need review and work now. Review these first.
status: merge me please
Pull requests that are ready to merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request ports the Fabric Rendering API, Fabric Renderer Indigo, and Fabric Model Loading API to 1.21.11.
Changes
QuadView,MutableQuadView, andQuadEmitternow store atlas data as an enumQuadAtlas.Due to the block/item atlas split, items rendered using modded quads may use either the block atlas or the item atlas, but each item layer is limited to using one atlas.This is no longer the case.QuadAtlasfield in quad headers.toVanillaandfromVanillamethods inQuadView,MutableQuadView, andQuadEmitterhave been removed due Mojang using unpacked vertex data inBakedQuad.BakedQuadno longer stores FRAPI data such as normals, color, or atlas!VANILLA_VERTEX_STRIDEandVANILLA_QUAD_STRIDEinQuadViewhave been removed.ModelBakeSettingsHelper#asQuadTransformnow takes aQuadAtlasSpriteGetterin place of aSpriteFinderto ensure that both item and block quad atlases have associated sprite finders.QuadAtlasSpriteGetterfunctional interface has been added forModelBakeSettingsHelper#asQuadTransform.BlockRenderDispatcherAccessor#getBlockEntityModelsGetterhas been removed in favor ofModelManager#specialBlockModelRenderer.fabric-model-loading-api-v1,fabric-renderer-api-v1, andfabric-renderer-indigomodules have been re-enabled.FabricLayerRenderState#setRenderTypeGetterandItemRenderTypeGetterto allow implementations ofItemModelto use both the block and item atlases on the same layer.