Skip to content
This repository was archived by the owner on Sep 10, 2022. It is now read-only.

Commit 6bf310c

Browse files
authored
Merge pull request #1 from EugenMayer/bootstrap4-dev
Update to Alpha 6 for Modal Support
2 parents b840b3e + c25f605 commit 6bf310c

File tree

10 files changed

+41
-22
lines changed

10 files changed

+41
-22
lines changed

.idea/jsLibraryMappings.xml

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.idea/libraries/bootstrap_dialog_node_modules.xml

Lines changed: 15 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bower.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
"README.md"
3232
],
3333
"dependencies": {
34-
"bootstrap": ">= 3.1.0",
34+
"bootstrap": ">= 3.1.0 || >= 4.0.0-alpha.3",
3535
"jquery": ">= 1.9.0"
3636
}
3737
}

dist/css/bootstrap-dialog.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
filter: alpha(opacity=100);
3434
}
3535
.bootstrap-dialog.type-default .modal-header {
36-
background-color: #ffffff;
36+
background-color: #fff;
3737
}
3838
.bootstrap-dialog.type-default .bootstrap-dialog-title {
3939
color: #333;

dist/js/bootstrap-dialog.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
* ================================================ */
4141
var Modal = $.fn.modal.Constructor;
4242
var BootstrapDialogModal = function(element, options) {
43-
if (/4\.0\.\d+/.test($.fn.modal.Constructor.VERSION)) {
43+
if (/4\.0\.\d+(-(alpha|beta|rc)\.\d+)?/.test($.fn.modal.Constructor.VERSION)) {
4444
return new Modal(element, options);
4545
} else {
4646
Modal.call(this, element, options);
@@ -54,7 +54,7 @@
5454
version = 'v3.2';
5555
} else if (/3\.3\.[1,2]/.test($.fn.modal.Constructor.VERSION)) {
5656
version = 'v3.3'; // v3.3.1, v3.3.2
57-
} else if (/4\.0\.\d+/.test($.fn.modal.Constructor.VERSION)) {
57+
} else if (/4\.0\.\d+(-(alpha|beta|rc)\.\d+)?/.test($.fn.modal.Constructor.VERSION)) {
5858
version = 'v4.0';
5959
} else {
6060
version = 'v3.3.4';

dist/js/bootstrap-dialog.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/less/bootstrap-dialog.less

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
//** Global background color for active items (e.g., navs or dropdowns).
112112
@component-active-bg: @brand-primary;
113113

114-
//** Width of the `border` for generating carets that indicator dropdowns.
114+
//** Width of the `border` for generating carets that indicate dropdowns.
115115
@caret-width-base: 4px;
116116
//** Carets increase slightly in size for larger components.
117117
@caret-width-large: 5px;
@@ -863,6 +863,8 @@
863863
@page-header-border-color: @gray-lighter;
864864
//** Width of horizontal description list titles
865865
@dl-horizontal-offset: @component-offset-horizontal;
866+
//** Point at which .dl-horizontal becomes horizontal
867+
@dl-horizontal-breakpoint: @grid-float-breakpoint;
866868
//** Horizontal line color.
867869
@hr-border: @gray-lighter;
868870

@@ -954,12 +956,9 @@
954956
&.disabled,
955957
&[disabled],
956958
fieldset[disabled] & {
957-
&,
958959
&:hover,
959960
&:focus,
960-
&.focus,
961-
&:active,
962-
&.active {
961+
&.focus {
963962
background-color: @background;
964963
border-color: @border;
965964
}
@@ -1256,8 +1255,8 @@
12561255
.container-fixed(@gutter: @grid-gutter-width) {
12571256
margin-right: auto;
12581257
margin-left: auto;
1259-
padding-left: (@gutter / 2);
1260-
padding-right: (@gutter / 2);
1258+
padding-left: floor((@gutter / 2));
1259+
padding-right: ceil((@gutter / 2));
12611260
&:extend(.clearfix all);
12621261
}
12631262

@@ -1379,7 +1378,7 @@
13791378
//
13801379
// Source: https://github.com/h5bp/html5-boilerplate/commit/aa0396eae757
13811380

1382-
// Deprecated as of v3.0.1 (will be removed in v4)
1381+
// Deprecated as of v3.0.1 (has been removed in v4)
13831382
.hide-text() {
13841383
font: ~"0/0" a;
13851384
color: transparent;
@@ -1627,9 +1626,9 @@
16271626
// WebKit-style focus
16281627

16291628
.tab-focus() {
1630-
// Default
1631-
outline: thin dotted;
1632-
// WebKit
1629+
// WebKit-specific. Other browsers will keep their default outline style.
1630+
// (Initially tried to also force default via `outline: initial`,
1631+
// but that seems to erroneously remove the outline in Firefox altogether.)
16331632
outline: 5px auto -webkit-focus-ring-color;
16341633
outline-offset: -2px;
16351634
}
@@ -1685,7 +1684,7 @@
16851684
// Vendor Prefixes
16861685
//
16871686
// All vendor mixins are deprecated as of v3.2.0 due to the introduction of
1688-
// Autoprefixer in our Gruntfile. They will be removed in v4.
1687+
// Autoprefixer in our Gruntfile. They have been removed in v4.
16891688

16901689
// - Animations
16911690
// - Backface visibility
@@ -1738,7 +1737,7 @@
17381737
// Prevent browsers from flickering when using CSS 3D transforms.
17391738
// Default value is `visible`, but can be changed to `hidden`
17401739

1741-
.backface-visibility(@visibility){
1740+
.backface-visibility(@visibility) {
17421741
-webkit-backface-visibility: @visibility;
17431742
-moz-backface-visibility: @visibility;
17441743
backface-visibility: @visibility;

gulpfile.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
"use strict";
44

55
var gulp = require("gulp"),
6-
eslint = require("gulp-eslint"),
76
less = require("gulp-less"),
87
minifyCSS = require("gulp-minify-css"),
98
path = require("path"),

src/css/bootstrap-dialog.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
filter: alpha(opacity=100);
3434
}
3535
.bootstrap-dialog.type-default .modal-header {
36-
background-color: #ffffff;
36+
background-color: #fff;
3737
}
3838
.bootstrap-dialog.type-default .bootstrap-dialog-title {
3939
color: #333;

src/js/bootstrap-dialog.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
* ================================================ */
4141
var Modal = $.fn.modal.Constructor;
4242
var BootstrapDialogModal = function(element, options) {
43-
if (/4\.0\.\d+/.test($.fn.modal.Constructor.VERSION)) {
43+
if (/4\.0\.\d+(-(alpha|beta|rc)\.\d+)?/.test($.fn.modal.Constructor.VERSION)) {
4444
return new Modal(element, options);
4545
} else {
4646
Modal.call(this, element, options);
@@ -54,7 +54,7 @@
5454
version = 'v3.2';
5555
} else if (/3\.3\.[1,2]/.test($.fn.modal.Constructor.VERSION)) {
5656
version = 'v3.3'; // v3.3.1, v3.3.2
57-
} else if (/4\.0\.\d+/.test($.fn.modal.Constructor.VERSION)) {
57+
} else if (/4\.0\.\d+(-(alpha|beta|rc)\.\d+)?/.test($.fn.modal.Constructor.VERSION)) {
5858
version = 'v4.0';
5959
} else {
6060
version = 'v3.3.4';

0 commit comments

Comments
 (0)